From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa1.mentor.iphmx.com (esa1.mentor.iphmx.com [68.232.129.153]) by sourceware.org (Postfix) with ESMTPS id 06DBF3858402 for ; Tue, 14 Sep 2021 23:43:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 06DBF3858402 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com IronPort-SDR: z89XClVkFU9E2p99Op3BJOiN9ouBM6G0nBCCMvuK68AYnwI/2HFWh82MHKclRjm9L0/6B/75po 1Gxwb3+m+SlA9aHSsjab+O0O8n3u9iMp8aDWVfGKK2ks2quGFTo+sHB3OyoF2wtwvX9Fb1LCLz LOCgZ/aOdhiztGrtJITlVkmPR05uhZC3XDUA49+d9QimGXXIfNon6nbSB1TU18b0ij2pAlSfxM 6o6N4DMvLNpky8ruzjtmTTxsSTpJiNU4dwnf4P7Pkym0K7bVm76x0tRtEkf7/vCG5GPKZ57tPe kjJxJv+Fy/vvZZky4ZQG6Qv8 X-IronPort-AV: E=Sophos;i="5.85,292,1624348800"; d="scan'208";a="68366746" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa1.mentor.iphmx.com with ESMTP; 14 Sep 2021 15:43:29 -0800 IronPort-SDR: 1YZ4TVL35JY+Q0/qy25mmDQk9tMxC0PA0g5kAhSgMMgv/yCEWsctbufyWIeLVUfCBsRuKUyua6 8Yx4RsHmXQYvaV5iM4LYV23cW7/ixI2WTP3Dpx+1qGXsAE6LIwdu9fnYit1dQ7XL5uxdJf5paO yd/MwbGrAlImVqLBhZtbhQVVksfvGgZwugDDZbC/ukK0ApMPKFU4yj+0s8NVYv0/sdgnGOVROl +OHVBIl98SG7bTcFRXoTshvmGjwX6VLxqxfys14JB4IP1dJFwEFIIusfqAVnlikNDhINHeEmuH XH4= Date: Tue, 14 Sep 2021 23:43:22 +0000 From: Joseph Myers X-X-Sender: jsm28@digraph.polyomino.org.uk To: Vincent Chen CC: , , Subject: Re: [RFC 5/5] RISC-V: Expand PTHREAD_STACK_MIN to support RVV environment In-Reply-To: <1631497278-29829-6-git-send-email-vincent.chen@sifive.com> Message-ID: References: <1631497278-29829-1-git-send-email-vincent.chen@sifive.com> <1631497278-29829-6-git-send-email-vincent.chen@sifive.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: SVR-IES-MBX-04.mgc.mentorg.com (139.181.222.4) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-Spam-Status: No, score=-3118.5 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Sep 2021 23:43:30 -0000 On Mon, 13 Sep 2021, Vincent Chen wrote: > In order to support all pthread operations in the RVV environment, here > PTHREAD_STACK_MIN is set to 4 times GLRO(dl_minsigstacksize), and the > default PTHREAD_STACK_MIN is expanded to 20K bytes. A change to PTHREAD_STACK_MIN has been considered an ABI change in the past, requiring new symbol versions for pthread_attr_setstack and pthread_attr_setstacksize to ensure that binaries built with the old PTHREAD_STACK_MIN definition continue to work rather than failing because the old size is too small. You may need symbol versioning updates for those functions in RISC-V if you make such a change. (All the existing versioning support for this in architecture-independent files assumes the change in value was done before libpthread was merged into libc, so there will be some extra work involved in being the first architecture to increase PTHREAD_STACK_MIN after that merge.) -- Joseph S. Myers joseph@codesourcery.com