From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <joseph_myers@mentor.com>
Received: from esa3.mentor.iphmx.com (esa3.mentor.iphmx.com [68.232.137.180])
 by sourceware.org (Postfix) with ESMTPS id 4A1123858C2C
 for <libc-alpha@sourceware.org>; Thu, 30 Sep 2021 15:08:06 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4A1123858C2C
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none)
 header.from=codesourcery.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com
IronPort-SDR: X7qf5Uq0LStJ35adsLr/1T+C+R89jn1Xqv8ov3hRsprhBX1TyH3g0SERrvhG0ucHtTfFtM5d1W
 +ZdM6X3asy64KwW799R/BlWd2YDB0XEo26HyzX3u1RJdKlUA2GcaK73exh6Nl1MHJtPAIULUiq
 JdJl/nrAU0hfAra6jmxIjN4YPWzFUFOdbAFzbmbLSi6b6pa5yc9eVE4lhJWGW6TTcfkhpOJgqa
 PPVDjFT3r+FgWm4TqassQP32s1JFqW30X975UEmlTCGvMsnXPS1nWRMnQVggi4gERzMiaWNuEo
 QDbS3vuzDOVf2AnoB5sEnFik
X-IronPort-AV: E=Sophos;i="5.85,336,1624348800"; d="scan'208";a="66502202"
Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165])
 by esa3.mentor.iphmx.com with ESMTP; 30 Sep 2021 07:08:03 -0800
IronPort-SDR: ydjFxF5CqWUHseh55kXyo55F2llt5lkOuMppH2DpR7ovkEwihOI2zPKmOdMdoRKej65hGSZQHv
 YK7ZDX9wux658i1H+PQUOnfCgkVf4hSKhXpRWnQotHHWEwc13Qutc/w18D3idSA4vcn2BEBs7Y
 vZQ2XOfB4B44C8OaO5JSJ41npdINQLOioR7z7/5hIksqwkjLRyH7GsS8oB9BA0ZGkzTT1+PYXt
 pnqZQz8sZEjEMZKCR2WD1YY7rO9jPNmi2Oq2c7i9PzPU3kXOah2z1wH1FugsE21Q5mz7DN5UOc
 s4w=
Date: Thu, 30 Sep 2021 15:07:57 +0000
From: Joseph Myers <joseph@codesourcery.com>
X-X-Sender: jsm28@digraph.polyomino.org.uk
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
CC: <libc-alpha@sourceware.org>, Jonathan Wakely <jwakely@redhat.com>
Subject: Re: [PATCH v2] Suppress -Wcast-qual warnings in bsearch
In-Reply-To: <069fcec4-d81f-3ea8-d87c-ff3b281dbe71@linaro.org>
Message-ID: <alpine.DEB.2.22.394.2109301506230.886109@digraph.polyomino.org.uk>
References: <YKUdWuzFbiAnWx+Y@redhat.com>
 <alpine.DEB.2.22.394.2105191535500.14970@digraph.polyomino.org.uk>
 <YKUzzZwNF3YajJaX@redhat.com>
 <CACb0b4mXELY54dcjrfaFjCcLJz56jOcaQH1kgVzFHFAp_7CcuQ@mail.gmail.com>
 <87czoq4a44.fsf@oldenburg.str.redhat.com>
 <069fcec4-d81f-3ea8-d87c-ff3b281dbe71@linaro.org>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
X-Originating-IP: [137.202.0.90]
X-ClientProxiedBy: SVR-IES-MBX-08.mgc.mentorg.com (139.181.222.8) To
 svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1)
X-Spam-Status: No, score=-3118.0 required=5.0 tests=BAYES_00,
 HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS,
 TXREP autolearn=no autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Sep 2021 15:08:07 -0000

On Thu, 30 Sep 2021, Adhemerval Zanella via Libc-alpha wrote:

> >>        else
> >> +#if __GNUC_PREREQ(4, 6)
> >> +# pragma GCC diagnostic push
> >> +# pragma GCC diagnostic ignored "-Wcast-qual"
> >> +#endif
> >>  	return (void *) __p;
> >> +#if __GNUC_PREREQ(4, 6)
> >> +# pragma GCC diagnostic pop
> >> +#endif
> >>      }

I think braces may need adding around those pragmas to avoid a pragma 
being considered the body of the else in some cases.

> For instance some math tests shows ulps failures that does not
> make much sense:

libm-test-support.c does use bsearch (in order to look up ulps by name in 
a table).

-- 
Joseph S. Myers
joseph@codesourcery.com