From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa4.mentor.iphmx.com (esa4.mentor.iphmx.com [68.232.137.252]) by sourceware.org (Postfix) with ESMTPS id E51D43858416 for ; Fri, 22 Oct 2021 00:18:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E51D43858416 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com IronPort-SDR: uXJIGr8s1XKCn8uh+e9DvnnqR6rb7lDGheetx+P2J49ULbmrc3gOrrS3TFqk03Np30B1pwc6yg gzzM8jYywyA0LnLCalgx8/6l/a4gLiVcXAib52eGlk1bSLEbLEaDgBK/CRWT4tNHNsHPtbakGn e3QlYpxnnjzkSk67Fp+0kdVAbgWqQTbf32qdz2NIgN986YZML8178xgfuh2bWkAuvFesdqmuTs 17aGyiuWnjfcrugoNEmNrV/vs/muIsvYZBoWsuR2Iro2WC2O3jOEifQ0/0fh7zwltjlsMpiwmE M0aUQ3mhSo8TSMND2a8oB8ge X-IronPort-AV: E=Sophos;i="5.87,170,1631606400"; d="scan'208";a="67508312" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa4.mentor.iphmx.com with ESMTP; 21 Oct 2021 16:18:16 -0800 IronPort-SDR: sBjX5WROqLIVtsD+bMYkORyXZ7PXFe7WoXPO4x/5JWV6u0dRYmTH1uNmxl6LqaIVdgi4EHMCYT Lcx3/NZIp0bZvEuWFSqePnwEna2K5ot0EebwK+Y4TgPdIfbEaDmCEz/kNK89tZigBZBqSYA6h4 f+2LIkUgaHp06WPwN6y17qkr3F7HzR9NWj3jy3E3hiufOmBP+3rdLf25P/Ip9XFzjyDNnL0RHY BR/bODqmkhtGzIOL1OWToH1AH1D8vuL9PkbCiMlbrBO7seMy2WUhCrmt/t+g8Fm9h4q7YXMzP+ Zq4= Date: Fri, 22 Oct 2021 00:18:10 +0000 From: Joseph Myers X-X-Sender: jsm28@digraph.polyomino.org.uk To: Noah Goldstein CC: GNU C Library Subject: Re: [PATCH v8 2/3] String: Add hidden defs for __memcmpeq() to enable internal usage In-Reply-To: Message-ID: References: <20210927203827.2852935-1-goldstein.w.n@gmail.com> <20211021223850.415607-1-goldstein.w.n@gmail.com> <20211021223850.415607-2-goldstein.w.n@gmail.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-Spam-Status: No, score=-3117.4 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Oct 2021 00:18:23 -0000 On Thu, 21 Oct 2021, Noah Goldstein via Libc-alpha wrote: > I have gone through all non-test .c files in GLIBC and replaced memcmp > with __memcmpeq where it makes sense. I can post that as a separate > patchset and we can decide whether it's a good idea there. I think it's a bad idea - it obfuscates the source code and it's better just to call the standard function, leave the code more readable and let the compiler optimize it as appropriate. -- Joseph S. Myers joseph@codesourcery.com