From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa1.mentor.iphmx.com (esa1.mentor.iphmx.com [68.232.129.153]) by sourceware.org (Postfix) with ESMTPS id 10A983858404; Tue, 9 Nov 2021 23:09:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 10A983858404 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com IronPort-SDR: TeDvdX0/YXqwyReAtL/I0H/L5aWpN5EAAg9rGZrZHu8CexGn1tSIC2erXq5itKtRek3Kc/wXoZ idx+TRQb+5aL5B0nVo2qQydSIpzmgt8n4Bi3d3xGTQIoNKV92tONLXtyJPFi5hbPR/XMJKPGHS w2qj8mWFAD05hTDjKYK9ZaLj4k+lHNchFUxjGNBxrF+d3CFLa7y0gf5pVMHI0ZO8w9h/lVqDXx bOGCsUm8UgesAIIxmiRFFBw205MdsoPZyDl5+7QOZIsuW9kA3+idjOfod4pf8TN97SQDupQQEw E17stL4nIg0hTxIpvOeiDKNP X-IronPort-AV: E=Sophos;i="5.87,221,1631606400"; d="scan'208";a="70747420" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa1.mentor.iphmx.com with ESMTP; 09 Nov 2021 15:09:13 -0800 IronPort-SDR: 22jb8Ddq17EnxUYzmTfQHXn8QpL31y850oT+7sZWWXMZgFjJyw4f1dTnCTsjvZgnoaf8nJlZXx E9VHQkcjsk+ZJun38CcAHxwN5iQoC4Tv1a77TCyvDI1h3cVo4dkGpJqxIe1ZfRTjLOQzSW8HxQ IRuqIV33hhPLKhycCud9+JyEuX+BSY2VCGLiyPCqIaJsX+0VoXXkvgDGHFBCMFCKDxTGTh9ZGQ ScHEBSQEhi2zSTbSbOYzErztebJLMkkG5oaUJUHVmI1tnTHoZm4w67RWR0zAiY+8Yk5R0LpSbR 2SA= Date: Tue, 9 Nov 2021 23:09:06 +0000 From: Joseph Myers X-X-Sender: jsm28@digraph.polyomino.org.uk To: Siddhesh Poyarekar CC: Adhemerval Zanella , , DJ Delorie Subject: Re: [PATCH v2] elf: Use the minimal malloc on tunables_strdup In-Reply-To: <87003cce-709a-ef50-9ab5-546ddae06b08@sourceware.org> Message-ID: References: <20211104131130.801849-1-adhemerval.zanella@linaro.org> <87003cce-709a-ef50-9ab5-546ddae06b08@sourceware.org> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-02.mgc.mentorg.com (139.181.222.2) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-Spam-Status: No, score=-3116.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP, T_FILL_THIS_FORM_SHORT autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Nov 2021 23:09:16 -0000 This seems to have caused build failures for many architectures (plus a localplt test failure for i686-gnu, "Missing required PLT reference: ld.so: __sbrk"). https://sourceware.org/pipermail/libc-testresults/2021q4/008843.html alpha-linux-gnu seems representative of the build failures: dl-minimal.c: In function '__chk_fail': dl-minimal.c:168:3: error: implicit declaration of function '_exit' [-Werror=implicit-function-declaration] 168 | _exit (127); | ^~~~~ dl-minimal.c:168:3: error: incompatible implicit declaration of built-in function '_exit' [-Werror=builtin-declaration-mismatch] In file included from : dl-minimal.c: At top level: ./../include/libc-symbols.h:549:33: error: '__EI___libc_fatal' aliased to undefined symbol '__GI___libc_fatal' 549 | extern thread __typeof (name) __EI_##name \ | ^~~~~ ./../include/libc-symbols.h:545:3: note: in expansion of macro '__hidden_ver2' 545 | __hidden_ver2 (, local, internal, name) | ^~~~~~~~~~~~~ ./../include/libc-symbols.h:554:41: note: in expansion of macro '__hidden_ver1' 554 | # define hidden_def(name) __hidden_ver1(__GI_##name, name, name); | ^~~~~~~~~~~~~ ./../include/libc-symbols.h:646:32: note: in expansion of macro 'hidden_def' 646 | # define rtld_hidden_def(name) hidden_def (name) | ^~~~~~~~~~ dl-minimal.c:162:1: note: in expansion of macro 'rtld_hidden_def' 162 | rtld_hidden_def (__libc_fatal) | ^~~~~~~~~~~~~~~ -- Joseph S. Myers joseph@codesourcery.com