From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa2.mentor.iphmx.com (esa2.mentor.iphmx.com [68.232.141.98]) by sourceware.org (Postfix) with ESMTPS id 3877A3858422 for ; Thu, 18 Nov 2021 22:22:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3877A3858422 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com IronPort-SDR: CJCGJ7pOBwvwBHH0wFY1UVoSp5CmTlRjks/PviEbuXPZNJl1bZ7kuG10zi7ifVqjkCMUeg8f14 PWKHOlZMx8CvjJEH1fl+qQJLCrWYJKJPAUow+KXLOJWBzl3J580q970Ds/wYAHMmM3V/3ma9BU SsaXXGlcpZSbKCeymPYf5H1BIb4fddGakO6QrGSRqkbQAUJTntGGYUiAZDO3qHe7+OgzXI7Wbn sKBFsJM4JoQOy6ThYfDUF61eCdt6OY3iMyaaMiA8H9o0v3nUo1o4CDlAirBOFgQTqDcWCJBcjB +/JPeqnrM/RajUl+Tqv9qq2/ X-IronPort-AV: E=Sophos;i="5.87,246,1631606400"; d="scan'208";a="68665515" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa2.mentor.iphmx.com with ESMTP; 18 Nov 2021 14:22:28 -0800 IronPort-SDR: y3AhfgpzuPrIpY43uLiB80EtxkEyHS7UGGyUTiNR3DK2f7Ck0UzgG6oxI2GnHU9MFgpOnDVSPu MZqyMAJY6x7U1o+1723h/5dhlqAdRpDiOe7M7fHXMIZIx0Zk69pVuB/yRd7Q7+VX7zuM81rhoX VQhuomHS/u439XPt9J+fINgdPhU+35t1ISAuJLlIvM8O8QMIqiedBgGnXE7zYxvz3d4wg40Vrj VE2BxeGa3E4uj+8MqNDiY2kCTm2VonAethQDL6r4OBE3KnZuOu+3zgxV3Ok7fSFOm8PGPY59iR MxA= Date: Thu, 18 Nov 2021 22:22:23 +0000 From: Joseph Myers X-X-Sender: jsm28@digraph.polyomino.org.uk To: Stafford Horne CC: GLIBC patches , Openrisc Subject: Re: [PATCH v2 05/13] or1k: Thread Local Storage support In-Reply-To: <20211113031639.2402161-6-shorne@gmail.com> Message-ID: References: <20211113031639.2402161-1-shorne@gmail.com> <20211113031639.2402161-6-shorne@gmail.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-05.mgc.mentorg.com (139.181.222.5) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-Spam-Status: No, score=-3122.7 required=5.0 tests=BAYES_00, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Nov 2021 22:22:32 -0000 On Sat, 13 Nov 2021, Stafford Horne via Libc-alpha wrote: > diff --git a/sysdeps/or1k/dl-tls.h b/sysdeps/or1k/dl-tls.h > new file mode 100644 > index 0000000000..f25645c715 > --- /dev/null > +++ b/sysdeps/or1k/dl-tls.h > @@ -0,0 +1,26 @@ > +/* Copyright (C) 2021 Free Software Foundation, Inc. Each file should have a one-line description on the line before the copyright notice. > diff --git a/sysdeps/or1k/libc-tls.c b/sysdeps/or1k/libc-tls.c > new file mode 100644 > index 0000000000..43571944dd > --- /dev/null > +++ b/sysdeps/or1k/libc-tls.c > @@ -0,0 +1,32 @@ > +/* Copyright (C) 2021 Free Software Foundation, Inc. Likewise. > diff --git a/sysdeps/or1k/stackinfo.h b/sysdeps/or1k/stackinfo.h > new file mode 100644 > index 0000000000..14e767c5bf > --- /dev/null > +++ b/sysdeps/or1k/stackinfo.h > @@ -0,0 +1,33 @@ > +/* Copyright (C) 2021 Free Software Foundation, Inc. Likewise. > +/* Default to an executable stack. PF_X can be overridden if PT_GNU_STACK is > + * present, but it is presumed absent. */ We don't use '*' at the start of second and subsequent lines of comments. (It seems unfortunate for a new port to default to executable stacks, but it looks like this is indeed what the Linux kernel port to OpenRISC does, given the lack of an override of the default VM_DATA_DEFAULT_FLAGS and VM_STACK_DEFAULT_FLAGS.) -- Joseph S. Myers joseph@codesourcery.com