From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa1.mentor.iphmx.com (esa1.mentor.iphmx.com [68.232.129.153]) by sourceware.org (Postfix) with ESMTPS id 27AD23858032 for ; Mon, 22 Nov 2021 18:19:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 27AD23858032 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com IronPort-SDR: MK5rWwB05r/hJpEBpjbeLt3e2U/Tx1hNUrTrXTZqggwR/ec+4ykeZ1GZ6WOPCWrDiQuS/z+49/ xqL4OVh1tXIiGSJUJSky2936t4MnbqCtpQ2xIz90hIXVVHH8QUav2N1UpFFCtG9YG1Diw3kc0e 3ezlccZdX2lZpQNxQyeLXShoXrkoD0jx71Z9vnmx5TYUFih4WqVYwb5zys34iDMPwcl4NKsUNL 3tQZIH4a06QvE3gN3LD2vABgdcbvtM+NImGSvMOVLO1+8wgwBc/z2z1UGfvioUuelcb/86qxKL kM2v7nBiLSfEXG2MFFy/nD/y X-IronPort-AV: E=Sophos;i="5.87,255,1631606400"; d="scan'208";a="71279087" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa1.mentor.iphmx.com with ESMTP; 22 Nov 2021 10:19:33 -0800 IronPort-SDR: ZPK1fno4o3UyRzlZLtGtS8FIhe0CF1DkKu35p8QtM2LOuAZ1C0qModKvx8MFZO+mBUuyWiSNlA J7JlusiPG0i/yanm+1iz6C4Mk8iQm5wAqfnX7bb6wdjDTxXleYFTNJOrUd+o+jqXQXgWvGX/Vc szbLERuMO+UA5/5t6jWKFkSHTAPhMVVf5zkIxu0shU9ILGdds9CoN/auRPZev4LAMgrgQWNQaa iRVYSU6LNysLFtt/0gEixThOYQhZ/gHey8QgugjiMgzshTUXx2tvBHnyXDwlsJGt85ITuoAXhF rEQ= Date: Mon, 22 Nov 2021 18:19:28 +0000 From: Joseph Myers X-X-Sender: jsm28@digraph.polyomino.org.uk To: , Subject: glibc -Werror=address build failure for Hurd with mainline GCC Message-ID: User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-02.mgc.mentorg.com (139.181.222.2) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-Spam-Status: No, score=-3116.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Nov 2021 18:19:35 -0000 The glibc build with GCC mainline has recently started failing for Hurd: report-wait.c: In function '_S_msg_report_wait': report-wait.c:129:12: error: the address of '_hurd_itimer_thread' will always evaluate as 'true' [-Werror=address] 129 | else if (&_hurd_itimer_thread && thread == _hurd_itimer_thread) | ^ This seems like a valid warning (the compiler can see the address can't be NULL), given the #if 0 above (but maybe the right fix depends on whether you want to keep the #if 0, and so keep it clear what would need to change if the #if 0 changed, or remove it): #if 0 /* libc.so.0.0 needs this defined, so make it a weak alias for now. */ extern thread_t _hurd_itimer_thread; /* XXX */ weak_extern (_hurd_itimer_thread) #else static thread_t default_hurd_itimer_thread; weak_alias (default_hurd_itimer_thread, _hurd_itimer_thread) #endif -- Joseph S. Myers joseph@codesourcery.com