From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa3.mentor.iphmx.com (esa3.mentor.iphmx.com [68.232.137.180]) by sourceware.org (Postfix) with ESMTPS id 79F023858D35 for ; Thu, 16 Dec 2021 19:26:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 79F023858D35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com IronPort-SDR: xcp5ggL3mzWJnG8a/owS454T2748aHggl/M18iRhoBybjwth3fUZy7bm7Mnlc4O5U9D8p0n++N b3fwWVxOFYT4hC+5AIC3O/QrFvDi6qiROSlDqz8FHZQpt6Ovad7z84PqsNrS/qhRqtuP+kbAIU e00jEs49R3Mp8dsoa2uoeZTLLlbwRaiU3ccYCmLxZQo9gWKWO6fuW8wZ4JOtuiBlbWWWNxkUBl I/R7d5MRgrhjCWmsHcmZPtsXxdvj8mdIKqf9izopn05BHW8sUspcRpUa6e9H1wPLIlU6rGDRhE zb+KdEBYbddOanT6earmBms8 X-IronPort-AV: E=Sophos;i="5.88,212,1635235200"; d="scan'208";a="69649301" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa3.mentor.iphmx.com with ESMTP; 16 Dec 2021 11:26:17 -0800 IronPort-SDR: XpeDFTe17Kf6xs/2+TbASEdTL/AO+5kbbBiLJUYetDkz8h4Qx2GFav2sweCaWXzxgiMK5alYXD ORps1hwm65P9JL31UzBUa/4tQ8CL7ri4XOnEb6cA3PlNYBJGWm3xZV6cH40ZhrqSUfmNeCJeCY EFqwmJjthTN3FEQK5Rg1sJ3k+iRlFyYX33kZf0LaijcYLrSi5s7MjoUQ4kdDCLV+Nf++3CheCc q6UxO08frS3pubKzfE0rp02b0QN/pCLEWW+4oSl5eyGqlzrAsAsNC9FsT75/Ps4EfjkjzpLhrB SRs= Date: Thu, 16 Dec 2021 19:26:11 +0000 From: Joseph Myers X-X-Sender: jsm28@digraph.polyomino.org.uk To: Adhemerval Zanella CC: Stafford Horne , GLIBC patches , Openrisc Subject: Re: [PATCH v3 05/13] or1k: Thread Local Storage support In-Reply-To: <2e024bfa-b5c2-2444-1b64-ca8f63e932b6@linaro.org> Message-ID: References: <20211210233456.4146479-1-shorne@gmail.com> <20211210233456.4146479-6-shorne@gmail.com> <2e024bfa-b5c2-2444-1b64-ca8f63e932b6@linaro.org> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: SVR-IES-MBX-08.mgc.mentorg.com (139.181.222.8) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-Spam-Status: No, score=-3116.2 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Dec 2021 19:26:18 -0000 On Thu, 16 Dec 2021, Adhemerval Zanella via Libc-alpha wrote: > > +/* Default to an executable stack. PF_X can be overridden if PT_GNU_STACK is > > + present, but it is presumed absent. */ > > +#define DEFAULT_STACK_PERMS (PF_R | PF_W | PF_X) > > Do you really a default stack executable? It is only done for older ABIs > and that's why PT_GNU_STACK was created. Newer ports, like arc and csky > assumes otherwise. I think this reflects what the kernel does (the relevant definitions being elf_read_implies_exec and VM_STACK_DEFAULT_FLAGS / VM_DATA_DEFAULT_FLAGS, none of which are overridden for openrisc, so the default VM_DATA_DEFAULT_FLAGS definition of VM_DATA_FLAGS_EXEC applies). -- Joseph S. Myers joseph@codesourcery.com