From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa4.mentor.iphmx.com (esa4.mentor.iphmx.com [68.232.137.252]) by sourceware.org (Postfix) with ESMTPS id 3FF1A3858C2C for ; Tue, 4 Jan 2022 18:37:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3FF1A3858C2C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com IronPort-SDR: EmC1CzZQPd5zBsoUenyL2fhFCj543sr6x7orYaiWVj66Sti5F5l3oTrqXwq5kM3yrJMvo/Lmw1 mit7Lgq7CMKR2Jm1Mci6N+5NZW9bKafWSzSUALWrX6TRAW9FKkU9Jdf5kbaN5LRLSmRXw99tYN Y6Wg0bAXyF8Yl8nLaB4hfRYIr4eSd4W27GqQIW4KkbOnsQBfxcLHVTS7ybfkWsmY8dxW/KlASV 2nJ3BY4jrxPc4/DKgRBbvOel5EdMqJSyu5BUE5szJT9tqB1oSkNvBT/0D0syDD6S087odcBHAu b6lKY8V7ceNhhehcTxUj8jol X-IronPort-AV: E=Sophos;i="5.88,261,1635235200"; d="scan'208";a="70379908" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa4.mentor.iphmx.com with ESMTP; 04 Jan 2022 10:37:24 -0800 IronPort-SDR: 62XpGbX/h1FTYe2y7Sb24Io7/9BPT++F+/bmCVUWIA9qdnvz4BbG1zjbIzm7Y4q8Vyo6a1+0KC oGr5E/auSq0JdgsiaY2D4MAakpw/9xYHGi+T9+hGsVxYDJkf5IIY5/ASVmo9KsVDP7fQLhnduc jqJW+DrKeXKsADL5821gJMXV1uFW7LUr5LItwXzQr6uRhFngN0jbnA/ximSrLkCbubzDSFrOID Nx3iWtE0EsaIWnnwGKwpd00EXWG6RLKXvzEVyG+8j34d/lnzl8RX/riKe99MHjBn3lPlQMeH/p LOs= Date: Tue, 4 Jan 2022 18:37:18 +0000 From: Joseph Myers X-X-Sender: jsm28@digraph.polyomino.org.uk To: "H.J. Lu" CC: Subject: Re: [PATCH] Properly check linker option in LIBC_LINKER_FEATURE [BZ #28738] In-Reply-To: <20220102141623.589517-1-hjl.tools@gmail.com> Message-ID: References: <20220102141623.589517-1-hjl.tools@gmail.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-02.mgc.mentorg.com (139.181.222.2) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-Spam-Status: No, score=-3115.8 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Jan 2022 18:37:43 -0000 On Sun, 2 Jan 2022, H.J. Lu via Libc-alpha wrote: > + if ${CC-cc} $CFLAGS $CPPFLAGS $LDFLAGS $no_ssp $2 -nostdlib \ > + -nostartfiles -fPIC -shared -o conftest.so conftest.c 2>&1 \ > + | grep "warning: $1 ignored" > /dev/null 2>&1; then If you check for specific English language text like that (which may not be a good idea, since binutils maintainers may expect to be able to rephrase messages without breaking glibc), you need to run the linker (and thus the compiler) with LC_ALL=C to avoid getting a translated message. -- Joseph S. Myers joseph@codesourcery.com