From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa4.mentor.iphmx.com (esa4.mentor.iphmx.com [68.232.137.252]) by sourceware.org (Postfix) with ESMTPS id 9C3B0385803B for ; Tue, 18 Jan 2022 21:03:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9C3B0385803B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com IronPort-SDR: GXmAvQVg2M9AUhbGT4sRL7zwZhcfKFaeQOemT8AXlRCAJ884Ap1nc55wc2EysxXdIpGPatokD4 E77mL4k+PIpVL7r7IGcXGJWy3qaoloBX/or9K3Il9ZCkn9xVztoOWNOpFOKm+mP0PXft00z0hn 6MnJYD3QfAivlTXj1jZ6IuAHGb9TVBfma57brQLr2RuG9cf1GrMMcSEmG5cbwCfn3MYqrp/DJ/ iCrnQWrEw38spHy06GuEgEaZxS7MNJYcDaszpCxKMPiA6VnD4Fphzp86NOge/gEcwzN+9mLuXt 5no= X-IronPort-AV: E=Sophos;i="5.88,298,1635235200"; d="scan'208";a="70897946" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa4.mentor.iphmx.com with ESMTP; 18 Jan 2022 13:03:09 -0800 IronPort-SDR: bdUAJ0bLMWokprSrOAjYO4iJBo3WQS9dLExleynuRTOj1IpUiep+iB7XfoSHbkaVjld4A7q7RA vBiGt7rQ1aFnVyfvtteZb3ZrMxlIOThGcJa+WZxgh5hE6CuYquD55AZeihIZXQhdDCgvlG9JnJ qQFmYoSXLszAbBg9y5eD80ie70C09seBaqWW9nM/BucnLneJwOhe5CgBRs2uHNdTMlugchVIQZ 1PCyWNA0did5Ff0V/PrNNtPAx2wQ2ZucPzEV0hj3EdJLwjYvMcwMK6MwkPt5pht+8iXs6WJbZV RE8= Date: Tue, 18 Jan 2022 21:03:04 +0000 From: Joseph Myers X-X-Sender: jsm28@digraph.polyomino.org.uk To: Stefan Liebler CC: Florian Weimer , Subject: Re: [PATCH 7/7] s390x: Use in early HWCAP check In-Reply-To: Message-ID: References: <201e517c6a751bebe505af99e35a9f8643066f31.1642162312.git.fweimer@redhat.com> <81a3cde1-250e-b04a-0037-4fb7f363fd42@linux.ibm.com> <87czkpjjan.fsf@oldenburg.str.redhat.com> <87sftli2xw.fsf@oldenburg.str.redhat.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-Spam-Status: No, score=-3115.4 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Jan 2022 21:03:14 -0000 The "elf: Move _dl_setup_hash to its own file" change (commit c90363403b57b3b7919061851cb3e6d9c85e784a) appears to have broken the build for MIPS (all ABIs). In file included from ../sysdeps/gnu/ldsodefs.h:46, from ../sysdeps/unix/sysv/linux/ldsodefs.h:25, from ../sysdeps/unix/sysv/linux/mips/ldsodefs.h:22, from dl-setup_hash.c:21: dl-setup_hash.c: In function '_dl_setup_hash': ../sysdeps/mips/ldsodefs.h:39:33: error: implicit declaration of function 'DT_MIPS'; did you mean 'EM_MIPS'? [-Werror=implicit-function-declaration] 39 | (hash32) += (map)->l_info[DT_MIPS (SYMTABNO)]->d_un.d_val - (symbias); \ | ^~~~~~~ dl-setup_hash.c:48:7: note: in expansion of macro 'ELF_MACHINE_XHASH_SETUP' 48 | ELF_MACHINE_XHASH_SETUP (hash32, symbias, map); | ^~~~~~~~~~~~~~~~~~~~~~~ ../sysdeps/mips/ldsodefs.h:39:42: error: 'SYMTABNO' undeclared (first use in this function) 39 | (hash32) += (map)->l_info[DT_MIPS (SYMTABNO)]->d_un.d_val - (symbias); \ | ^~~~~~~~ dl-setup_hash.c:48:7: note: in expansion of macro 'ELF_MACHINE_XHASH_SETUP' 48 | ELF_MACHINE_XHASH_SETUP (hash32, symbias, map); | ^~~~~~~~~~~~~~~~~~~~~~~ ../sysdeps/mips/ldsodefs.h:39:42: note: each undeclared identifier is reported only once for each function it appears in 39 | (hash32) += (map)->l_info[DT_MIPS (SYMTABNO)]->d_un.d_val - (symbias); \ | ^~~~~~~~ dl-setup_hash.c:48:7: note: in expansion of macro 'ELF_MACHINE_XHASH_SETUP' 48 | ELF_MACHINE_XHASH_SETUP (hash32, symbias, map); | ^~~~~~~~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors -- Joseph S. Myers joseph@codesourcery.com