From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa3.mentor.iphmx.com (esa3.mentor.iphmx.com [68.232.137.180]) by sourceware.org (Postfix) with ESMTPS id 948AA3858031 for ; Mon, 24 Jan 2022 21:21:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 948AA3858031 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com IronPort-SDR: IZs/CU/q+Me8q4RChxAC43R5L+C9i4//YQ/Xe+LHCSHcEcVXxHQRGrMmmEj2ONNlmzIMT/K//9 VPvVfzDIjWDDKCCzncmXjnGfZlikaCMd2UPHyjbAAqVi7uGtEjHA91WmDQ5V2tEfbZRukUzkOu OTq5bcmfYpTGlVFK3/pnQ4oNNcxSsXU1HdQI9mC8S/ErL59HCSZZQF+MyrwWGf0Y/Kaypn4Sv6 P1UPO79M3yF8HcLD8uPYhUVLpPoo+UBCsdLWZdUwHwRDwaOlYR5b7kvDla13nRlu6rmt/4htfA jHlVxCMK6wMRkDNQ3OPB/TZe X-IronPort-AV: E=Sophos;i="5.88,313,1635235200"; d="scan'208";a="71002223" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa3.mentor.iphmx.com with ESMTP; 24 Jan 2022 13:21:56 -0800 IronPort-SDR: 52ddK0YC/w3YcW9E4hPmIDwYona2HbpgjT49msXgFLTMw0pBfjlaJZJCMXuvYCKSDYMrl9xYG8 evUWePGXbCeMtMEzp1Ylx4UT4jQ4APPEHPT/0BYoP7T3iF+clf+rjeRaXy0O3DM32PhIBA0Qx+ ld9YRHi11hIk3/P6lM/zNpvFFwaf9FyHKj7JGhJUNIzjukqJkC07jeV/2uhf4YiPNxB1PySNux r1mG8GAN4juYH9RJPtatkY4Ceteocx+Qwqsys2QvSWgKKzPCTsQDjWDKsjDvcoNUzZCO9648Sy 6u4= Date: Mon, 24 Jan 2022 21:21:50 +0000 From: Joseph Myers X-X-Sender: jsm28@digraph.polyomino.org.uk To: Adhemerval Zanella CC: "H.J. Lu" , , Florian Weimer Subject: Re: [PATCH v9 1/3] elf: Add a test for PT_LOAD segments with mixed p_align [BZ #28676] In-Reply-To: <812466f3-14b4-e9af-9f97-35707c4bd111@linaro.org> Message-ID: References: <20220121211205.268178-1-hjl.tools@gmail.com> <20220121211205.268178-2-hjl.tools@gmail.com> <812466f3-14b4-e9af-9f97-35707c4bd111@linaro.org> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-05.mgc.mentorg.com (139.181.222.5) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-Spam-Status: No, score=-3115.3 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Jan 2022 21:21:59 -0000 On Mon, 24 Jan 2022, Adhemerval Zanella via Libc-alpha wrote: > > +# Make a copy of tst-p_alignmod-base.so and lower p_align of the first > > +# PT_LOAD segment. > > +$(objpfx)tst-p_alignmod1.so: $(objpfx)tst-p_alignmod1-edit \ > > + $(objpfx)tst-p_alignmod-base.so > > + rm -f $@ > > + cp $(objpfx)tst-p_alignmod-base.so $@ > > + $(test-wrapper-env) $(run-program-env) $(rtld-prefix) \ > > + $(objpfx)tst-p_alignmod1-edit $@ This has broken the testsuite build for all cross-compilation situations not running the newly built tests. You can't run a program built with the new glibc unless $(run-built-tests) is yes. Either disable everything depending on running these programs unless $(run-built-tests) is yes or revert the commits adding them (reimplementing the editing in Python using only the standard library might be a possibility for the future; building the C program for $build wouldn't be a good idea and we'd like to phase out the remaining two tests that do use C programs for $build by subsuming them in conformtest). -- Joseph S. Myers joseph@codesourcery.com