From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa1.mentor.iphmx.com (esa1.mentor.iphmx.com [68.232.129.153]) by sourceware.org (Postfix) with ESMTPS id D92863858D20 for ; Fri, 4 Feb 2022 19:46:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D92863858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com IronPort-SDR: O9ZD/nClAayviMKwcF6zACXkpIC253qQ0ZfrBDvusjeZO/NirHfv4KiU3+0DywcTvj0RsiiFbv WQ9YxpNJECdxOsJYlWD+udae4k82/1TUxlQpoU5DqL+ix014jffiitjY/pgFMb9jj2bgffQC98 cZO7nlFeABC5oAba3PBFMh2eK18sDlT2jM8RMdUEu3MXmgPj/mAkpWqVmYSF5q0jjZpTZkmFbS DEBLd0TlhRCLPcqVrhENur/XwAHhBzoGl3KKHxZTlpYUlocXOJWs4z0De854VuJdoNh97rXlg+ PiWRbS1vWqvMZ/CIGjKvIGtZ X-IronPort-AV: E=Sophos;i="5.88,343,1635235200"; d="scan'208";a="74156892" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa1.mentor.iphmx.com with ESMTP; 04 Feb 2022 11:46:54 -0800 IronPort-SDR: qVZROwrRDTlOWl5dMzxw/ylx4n3B3igXBTCZTADhDhJtz9WNPevpOsMyUec7ASyAkUPdNih4r/ 1PrpLHlV9tfnbrzfk6OCT0Mdr+mLtwI+8Jumcx1d6euwlTEam/hRYy48tluUzlojq4dkXnCJu4 BY8h4MAphpQFpof3Gni7mtmwA+35sD5A6ZDI6VdjXFnQwk5IoC843tmTBsPRYt0s4R0oJ62TlO hJKjFwXlipkx359lR5oiT1oFF8E8p0v6AB/HUAYI+kxtifNWfSnWdgZgJncLIpsRwArbpG1xGH QZo= Date: Fri, 4 Feb 2022 19:46:49 +0000 From: Joseph Myers X-X-Sender: jsm28@digraph.polyomino.org.uk To: Adhemerval Zanella CC: Subject: Re: [PATCH 01/15] linux: Add pidfd_open In-Reply-To: <20220203174634.3474775-2-adhemerval.zanella@linaro.org> Message-ID: References: <20220203174634.3474775-1-adhemerval.zanella@linaro.org> <20220203174634.3474775-2-adhemerval.zanella@linaro.org> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-Spam-Status: No, score=-3115.0 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Feb 2022 19:46:56 -0000 On Thu, 3 Feb 2022, Adhemerval Zanella via Libc-alpha wrote: > + sys.exit(glibcextract.compare_macro_consts( > + '#include \n', > + '#include \n' > + '#include \n', > + args.cc, > + 'PIDFD_.*')) Are you sure about doing this sort of comparison without the kind of kernel version checks done in tst-mman-consts.py? That's only OK if (a) all the compared macros are present in the oldest kernel headers version supported for building glibc and (b) no matching macros will be added in any future kernel version. -- Joseph S. Myers joseph@codesourcery.com