From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa3.mentor.iphmx.com (esa3.mentor.iphmx.com [68.232.137.180]) by sourceware.org (Postfix) with ESMTPS id BA01E3858D20 for ; Fri, 4 Feb 2022 20:40:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BA01E3858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com IronPort-SDR: Pdie5uSngtvw+Z7vmeM2BmWuI+DMyb0qpYuUZ7+dWfP2lTgh/mSF+REKeYwTlFgp4IhV6lbeap wJcJih4dULLT88KWwDJvSmRL+bxNZgBLc9ob+MWREFqUP4myWPMd8MPP5Cdi3zLoY+iFrRsU6k K1o7xKAc11ZRF5Y0tU2A4nitxffCYtEue4JEREE4iPwszmDqgRllKHwLjLHtt267Ent9+V6RR2 k4ZXPtnJP68scMbeU23I12vZmNz2VXEZVlqXMyuA2ZM+16K8KAoZJ7EeYrM24VkZgHYdWguVwk 4/LX+i+NjqUmvriaLnfLhtIU X-IronPort-AV: E=Sophos;i="5.88,343,1635235200"; d="scan'208";a="71449392" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa3.mentor.iphmx.com with ESMTP; 04 Feb 2022 12:40:53 -0800 IronPort-SDR: o4L5yA0bJp13mF0AehKdJuTOAXSKIvccUspLgzt1xe8Dxlmh5Rj7JGN/NZXSYkbOCfCnS8A4/9 uKZjNmj1h6PFgypYT4ylhei6CKfeC9rwOo+wvmzPP8OHqa3zT6zts21Vztun4onaFgOPU0/QC4 rGW40u7HJf7BXs1sA/Qtzav0gRfd+8hZltHW5vqOndZrzj+NpkOpei7pzNbBefnO228l7n3M4o 8tbdDAjJoycq64+FgypJXexhYLR2kLPLK+8sZBNcW8afx9lsaTMYhoIOjVpJwm1KoCGIpbsnSx SFk= Date: Fri, 4 Feb 2022 20:40:47 +0000 From: Joseph Myers X-X-Sender: jsm28@digraph.polyomino.org.uk To: Carlos O'Donell CC: Subject: Re: [PATCH v3 5/5] avoid -Wuse-after-free [BZ #26779] In-Reply-To: <942c6008-05c2-351c-ad35-18b724bbc8f6@redhat.com> Message-ID: References: <53f20975-a2c9-674d-2a43-b1b323ee545c@gmail.com> <50baa5fb-c1ee-f7dc-b7d6-cf4587782062@gmail.com> <3ad704bb-a061-1dc2-3b6d-8343f70a3c92@gmail.com> <7b1e2fda-b440-ad77-4586-7e73b7c927b0@redhat.com> <942c6008-05c2-351c-ad35-18b724bbc8f6@redhat.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: SVR-IES-MBX-08.mgc.mentorg.com (139.181.222.8) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-Spam-Status: No, score=-3115.0 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Feb 2022 20:40:55 -0000 On Mon, 31 Jan 2022, Carlos O'Donell via Libc-alpha wrote: > On 1/28/22 12:51, Joseph Myers wrote: > > On Fri, 28 Jan 2022, Carlos O'Donell via Libc-alpha wrote: > > > >> I'm going to look at these right now. I want clean gcc 12 glibc 2.35 > >> results before we release. > > > > There are also three ICE bugs in GCC 12 preventing glibc from building, so > > you won't get fully clean build-many-glibcs.py results with just glibc > > fixes. GCC bug 103722 on sh4, bug 104153 on or1k and 104154 on arc (the > > last two reported by Jeff based on ICEs building newlib, but the ICEs I > > see building glibc are in the same place in the compiler, so probably the > > same bugs). > > Thanks. > > I just fixed the last -Wuse-after-free bug. I think there are still some more -Wuse-after-free issues building the testsuite. https://sourceware.org/pipermail/libc-testresults/2022q1/009283.html s390x-linux-gnu-O3 failures are as shown at . hppa-linux-gnu, microblaze-linux-gnu, microblazeel-linux-gnu, glibcs-sparcv8-linux-gnu-leon3, sparcv9-linux-gnu, sparcv9-linux-gnu-disable-multi-arch: In function 'do_test', inlined from 'legacy_test_function' at ../test-skeleton.c:55:10:tst-realloc.c:134:12: error: pointer 'p' may be used after 'realloc' [-Werror=use-after-free] 134 | if (c[i] != 0xff) | ~^~~ tst-realloc.c:124:7: note: call to 'realloc' here 124 | c = realloc (p, -1); | ^~~~~~~~~~~~~~~ -- Joseph S. Myers joseph@codesourcery.com