From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa1.mentor.iphmx.com (esa1.mentor.iphmx.com [68.232.129.153]) by sourceware.org (Postfix) with ESMTPS id AE32E385E004 for ; Mon, 21 Mar 2022 18:18:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AE32E385E004 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.90,199,1643702400"; d="scan'208";a="76004928" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa1.mentor.iphmx.com with ESMTP; 21 Mar 2022 10:18:54 -0800 IronPort-SDR: QpfNyQSO+ad/H2o+99KokqBYomvXybDvCa0YHZGqiJFL0NSalGYmzq5sBIKXXSSSXyoSbANCzg nxP/vxoHvuPtbXONFHOl7mDjPfWMAvwLJS/5TyT132IcDCeKCe1iWw7B7QD2Vi8bdj4CR2BdXZ lutRBfR8CwLphZKjXddMi9voVTpogVtgHVNejbQDxGacSxGhUHamdyAFoaRM4NRP6k+e5rLabg uGuoBekzG4jI5qMImTs/r1AIXAGpDY8ixsunvcCy8mGox8DeJTcJwZ7chi/7eqLbaxmiB3diKh K+E= Date: Mon, 21 Mar 2022 18:18:22 +0000 From: Joseph Myers X-X-Sender: jsm28@digraph.polyomino.org.uk To: Ricardo Bittencourt CC: Subject: Re: [PATCH] string: Replace outdated comments in strlen(). In-Reply-To: <20220320010442.991728-1-bluepenguin@gmail.com> Message-ID: References: <20220320010442.991728-1-bluepenguin@gmail.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-09.mgc.mentorg.com (139.181.222.9) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-Spam-Status: No, score=-3114.2 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Mar 2022 18:18:59 -0000 Some incidental comments (this is not a review of the patch and should not delay it going in): * Do I understand correctly that this is a *different* comment issue from the one described in bug 5806 with comments in various string functions? (Maybe the issue described in comment#10 in that bug?) * I'd still like to see the generic string function improvements discussed in that bug getting into glibc at some point. -- Joseph S. Myers joseph@codesourcery.com