From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa3.mentor.iphmx.com (esa3.mentor.iphmx.com [68.232.137.180]) by sourceware.org (Postfix) with ESMTPS id 206023858D37 for ; Mon, 4 Apr 2022 21:30:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 206023858D37 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.90,235,1643702400"; d="scan'208";a="73841692" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa3.mentor.iphmx.com with ESMTP; 04 Apr 2022 13:30:54 -0800 IronPort-SDR: K8GPkgfHaMrpOHYin5QEOHCQI0VTA7IM91eMOvSzqCd1w6yJM1hmMDqN02Qga+RDMFPWux5E9I B2iuYdNtrbVThnM+IcdWjXKFjk+dt1+jmvG899OCMX1yZHLKUf6KydfvdlKldRsrtdarGsYHtA OPr86Ti8h0lvxgy2gaVSzu8wz++H0m6219rYQ8eAFkMFHupplNe2M9WbADWAdk5aphJ3k0c5hr H3qksY9g7WKeFcXUPfP6Zi4IX3FiEk5Xo0YK9V0IiX/pg6uwVF+oX37LOWUvGDvnH333qaMjhd f+w= Date: Mon, 4 Apr 2022 21:30:48 +0000 From: Joseph Myers X-X-Sender: jsm28@digraph.polyomino.org.uk To: Adhemerval Zanella CC: Subject: Re: [PATCH] math: Add math-use-builtins-fabs In-Reply-To: <20220404205805.701759-1-adhemerval.zanella@linaro.org> Message-ID: References: <20220404205805.701759-1-adhemerval.zanella@linaro.org> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-15.mgc.mentorg.com (139.181.222.15) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-Spam-Status: No, score=-3114.0 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Apr 2022 21:30:56 -0000 On Mon, 4 Apr 2022, Adhemerval Zanella via Libc-alpha wrote: > Both float and double are assumed to be supported (since generic > implementation uses it without a fallback), only long double and > float128 are defined. The only case where built-in fabs (or copysign) may not work properly is IBM long double in the soft-float case (see sysdeps/powerpc/nofpu/Makefile). I'd expect the default to be that it works with an override for long double fabs in that one soft-float case. > On ia64 it also fixes: > > math/test-float64x-fabs > math/test-ldouble-fabs If this is fixing a bug that was user-visible in a release, there should be a corresponding report in Bugzilla. -- Joseph S. Myers joseph@codesourcery.com