From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa2.mentor.iphmx.com (esa2.mentor.iphmx.com [68.232.141.98]) by sourceware.org (Postfix) with ESMTPS id CD719385803E for ; Thu, 14 Apr 2022 22:21:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CD719385803E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.90,260,1643702400"; d="scan'208";a="74540948" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa2.mentor.iphmx.com with ESMTP; 14 Apr 2022 14:21:39 -0800 IronPort-SDR: vonnabVS+1saPSeG+VsWT20ooktGYh15lkde9F2CCbvXEVdiPTnESpWFSLNkdH1FhFfqJ9xBXS cq4wIUOQSk5/RlQT7og9KoKJLbi6WlPw8aKNRT1kIuEvhMsOuB9ZPyk24jfJvPLgmyZ6x2ol0j OfmMKtlerEmC59szxl+1CZRe/b0tkIoT77BS9PZCsMDkbGUaHF5+EU+UP3pj6vpNc6Wng47oik th7h93QAKc4ciVc/pAq7I7zAZpcrV2KvFNFtsw+lEXOIyecugJ89q3AZ6l+cbVOZvkqSxPY2i5 VNs= Date: Thu, 14 Apr 2022 22:21:34 +0000 From: Joseph Myers X-X-Sender: jsm28@digraph.polyomino.org.uk To: Noah Goldstein CC: Subject: Re: [PATCH v1 1/2] stdlib: Refactor {u}int_fast defs in stdint In-Reply-To: <20220411010913.1061799-1-goldstein.w.n@gmail.com> Message-ID: References: <20220411010913.1061799-1-goldstein.w.n@gmail.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: SVR-IES-MBX-07.mgc.mentorg.com (139.181.222.7) To svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) X-Spam-Status: No, score=-3113.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Apr 2022 22:21:42 -0000 On Sun, 10 Apr 2022, Noah Goldstein via Libc-alpha wrote: > The goal is to make it easier to provide system specific defs for the > sizes of {u}int_fast{8|16|32|64}. > > Note this commit does not change any of the previous values. > > Full xcheck passes on x86_64. > --- > stdlib/stdint.h | 70 +----------------------- > sysdeps/generic/int-fast.h | 107 +++++++++++++++++++++++++++++++++++++ stdint.h is an installed header, so any headers it includes must also be installed headers (i.e. listed in headers in Makefile). Any installed header whose name is not a public API should be in bits/, and this header would clearly fall in that category - no user should ever #include themselves. -- Joseph S. Myers joseph@codesourcery.com