From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa1.mentor.iphmx.com (esa1.mentor.iphmx.com [68.232.129.153]) by sourceware.org (Postfix) with ESMTPS id 8E2DF3858D1E for ; Tue, 19 Jul 2022 21:08:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8E2DF3858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.92,285,1650960000"; d="scan'208";a="82690877" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa1.mentor.iphmx.com with ESMTP; 19 Jul 2022 13:08:20 -0800 IronPort-SDR: 1avVvFwF6I33Z75MMF6/jxxuZJtxxZq3o+hhj2aGIU5P39vP/dXqKDQ9PERuHoZWB2BzLnpF/I PToH+jLXBa/wV7hNvmBUMOkL3aUavowaJR84q/+RWj++otktUYfKEcwp+k0Nma+pGLDxZwqto/ d1ZEsUBgNVEoH9I17ass0mNjDIxDcyJPeopfmi2bDfSr0UIEAo6kKaD/Jt61ZerEXlo2aMOcX8 N1py7a0P/dcgwnm+Rw0eekogcKU7s1xZO3B2eYC6K94Ufz2Pq5JgDQ99zjOKjzuotCZeaK7o1t 4/I= Date: Tue, 19 Jul 2022 21:08:15 +0000 From: Joseph Myers X-X-Sender: jsm28@digraph.polyomino.org.uk To: Adhemerval Zanella CC: Tom Honermann , Subject: Re: [PATCH v4 2/3] stdlib: Implement mbrtoc8(), c8rtomb(), and the char8_t typedef. In-Reply-To: Message-ID: References: <20220630125215.6052-1-tom@honermann.net> <20220630125215.6052-3-tom@honermann.net> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: SVR-IES-MBX-07.mgc.mentorg.com (139.181.222.7) To svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) X-Spam-Status: No, score=-3112.3 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jul 2022 21:08:22 -0000 This change appears to introduce a failure of wcsmbs/check-installed-headers-cxx with GCC mainline, because uchar.h now produces: ../wcsmbs/uchar.h:38:23: error: identifier 'char8_t' is a keyword in C++20 [-Werror=c++20-compat] 38 | typedef unsigned char char8_t; (recall we want our installed headers to avoid warnings *without* relying on the default disabling of warnings in system headers). Unfortunately, GCC for C++ doesn't disable -Wc++20-compat inside __extension__ (unlike what the C front end does), so simply adding __extension__ to that declaration wouldn't help, but we could use diagnostic disabling pragmas (as already done in some installed headers). -- Joseph S. Myers joseph@codesourcery.com