From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa2.mentor.iphmx.com (esa2.mentor.iphmx.com [68.232.141.98]) by sourceware.org (Postfix) with ESMTPS id 45A303858C2F for ; Mon, 15 Aug 2022 20:46:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 45A303858C2F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.93,239,1654588800"; d="scan'208";a="81337576" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa2.mentor.iphmx.com with ESMTP; 15 Aug 2022 12:46:24 -0800 IronPort-SDR: ubC3Je9F9I5MkcFiDntG/Zxq4jaTxhQxOyx+l+de9Rtmz/70wDvCIdIP64xwMdAnbImbixKHhi 5Fxv0QuBnB0xNV/o8cQBn7N3tJemlfuwRdixi9Irub4qsWkihYY5x9vWHnm5+lMsXVEaVPrtaD qdppBArzKutSdG8FIcUH6xAeZzRoYoZsY8BSR7jPrerPod2EI53/1I7aK96tgHD7BVJndexJLB AGkya4GV+WEyi1nOOZDS9+uiQ//J9YtwzYVN5mRic2nivnC7ZhxPXVigKWX3pl599fhTKNnlrG dwE= Date: Mon, 15 Aug 2022 20:46:19 +0000 From: Joseph Myers X-X-Sender: jsm28@digraph.polyomino.org.uk To: Carlos O'Donell CC: caiyinyu , , , , Subject: Re: [PATCH 0/2] LoongArch: Add optimized functions. In-Reply-To: Message-ID: References: <20220815085718.4110353-1-caiyinyu@loongson.cn> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-11.mgc.mentorg.com (139.181.222.11) To svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) X-Spam-Status: No, score=-3111.8 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Aug 2022 20:46:27 -0000 On Mon, 15 Aug 2022, Carlos O'Donell via Libc-alpha wrote: > On 8/15/22 04:57, caiyinyu wrote: > > Tested on LoongArch machine: gcc 13.0.0, Linux kernel 5.19.0 rc2, > > binutils branch master 2eb132bdfb9. > > Could you please post microbenchmark results for these changes? > > How much faster are they from the generic versions? Note that so far we haven't merged the improved generic string functions that were posted a while back (https://sourceware.org/legacy-ml/libc-alpha/2018-01/msg00318.html is the version linked from https://sourceware.org/glibc/wiki/NewPorts - don't know if it's the most recent version). So even if assembly versions are better than the current generic string functions, they might not be better than improved generic versions with architecture-specific implementations of the headers to provide per-architecture tuning. -- Joseph S. Myers joseph@codesourcery.com