From: Joseph Myers <joseph@codesourcery.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: <libc-alpha@sourceware.org>
Subject: Re: [PATCH] Use '%z' instead of '%Z' on printf functions
Date: Wed, 31 Aug 2022 19:34:11 +0000 [thread overview]
Message-ID: <alpine.DEB.2.22.394.2208311931540.498823@digraph.polyomino.org.uk> (raw)
In-Reply-To: <20220831181415.3875642-1-adhemerval.zanella@linaro.org>
On Wed, 31 Aug 2022, Adhemerval Zanella via Libc-alpha wrote:
> The Z modifier is a nonstandard synonymn for z (that predates z
> itself) and compiler might issue an warning for in invalid
> conversion specifier.
> stdio-common/bug1.c | 4 ++--
> stdio-common/bug5.c | 2 +-
> stdio-common/test_rdwr.c | 10 +++++-----
> stdio-common/tst-fphex.c | 4 ++--
> stdio-common/tstgetln.c | 2 +-
Where changing testcases, have you made sure that there is still adequate
test coverage for the %Z extension (possibly in tests dedicated to that
purpose rather than incidental use in other tests)? (For everything
outside of stdio tests, using %z certainly makes sense.)
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2022-08-31 19:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-31 18:14 Adhemerval Zanella
2022-08-31 19:34 ` Joseph Myers [this message]
2022-09-01 13:00 ` Adhemerval Zanella Netto
2022-09-01 13:02 Adhemerval Zanella
2022-09-22 10:44 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2208311931540.498823@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).