From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa2.mentor.iphmx.com (esa2.mentor.iphmx.com [68.232.141.98]) by sourceware.org (Postfix) with ESMTPS id 501203858024 for ; Wed, 31 Aug 2022 19:34:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 501203858024 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.93,278,1654588800"; d="scan'208";a="82341526" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa2.mentor.iphmx.com with ESMTP; 31 Aug 2022 11:34:17 -0800 IronPort-SDR: RrB61knyYtflItEd/Dt6T2/zZoXwT5+eAIkBOXbXdOxB5iwHvAUt/BN71vgt88XiHKXnjP21Un Hsh5eQLtfNDXPthRPknUgZbbqzaSNgH9btuT2UTCQNodip8nqL2y4PSL8guxXXbH4Wd42HLp39 6ZD76Z+AS9P65vU3jEb41omkyaYS8uViVhs4I493kVZKpC2JKSTw/xXnfz4YhROPvoa4tEpTIh f8/QjZfaZD7gZZLyG1gXms+XUfY3eV1rEecIswnG/q61hFctEe0OnLEALFYK8oiDRZIze4B0sk oAc= Date: Wed, 31 Aug 2022 19:34:11 +0000 From: Joseph Myers X-X-Sender: jsm28@digraph.polyomino.org.uk To: Adhemerval Zanella CC: Subject: Re: [PATCH] Use '%z' instead of '%Z' on printf functions In-Reply-To: <20220831181415.3875642-1-adhemerval.zanella@linaro.org> Message-ID: References: <20220831181415.3875642-1-adhemerval.zanella@linaro.org> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-09.mgc.mentorg.com (139.181.222.9) To svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) X-Spam-Status: No, score=-3111.4 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, 31 Aug 2022, Adhemerval Zanella via Libc-alpha wrote: > The Z modifier is a nonstandard synonymn for z (that predates z > itself) and compiler might issue an warning for in invalid > conversion specifier. > stdio-common/bug1.c | 4 ++-- > stdio-common/bug5.c | 2 +- > stdio-common/test_rdwr.c | 10 +++++----- > stdio-common/tst-fphex.c | 4 ++-- > stdio-common/tstgetln.c | 2 +- Where changing testcases, have you made sure that there is still adequate test coverage for the %Z extension (possibly in tests dedicated to that purpose rather than incidental use in other tests)? (For everything outside of stdio tests, using %z certainly makes sense.) -- Joseph S. Myers joseph@codesourcery.com