From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa2.mentor.iphmx.com (esa2.mentor.iphmx.com [68.232.141.98]) by sourceware.org (Postfix) with ESMTPS id 1817E395253F for ; Sun, 18 Sep 2022 05:32:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1817E395253F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.93,323,1654588800"; d="scan'208";a="83236357" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa2.mentor.iphmx.com with ESMTP; 17 Sep 2022 21:32:25 -0800 IronPort-SDR: iwR02mX4B905WHqYb+VhYf6vQEX2Ad56sSYpvnIfUA7/lGeWtz10nU8PJdFUeYmI+xiwB1GyqU LQY4w7lYkce6th1QRXJRXew3PuVHs6Va3uo/3kCUIGa4OAGGMP2MKHCJSm5GSM3oM84N0LY5O4 iVErJHuCObZDnon9flClbWPYoUKUjNj1KuS1ScXCNgvwSYqFwDronCqJGGgVT6blECElIlZxP0 T1JzAYANXnpQRS/hz4XA9lvzl5CzHdH8qUA/wz6LWlXbbz97sHFm9FYtKQX2DP9dC1COwXxj4x bQ4= Date: Sun, 18 Sep 2022 05:32:19 +0000 From: Joseph Myers X-X-Sender: jsm28@digraph.polyomino.org.uk To: Letu Ren CC: , Subject: Re: [PATCH v2] stdlib/strfrom: Change -NAN test to multiple possible results (bug 29501) In-Reply-To: <20220917061328.8620-1-fantasquex@gmail.com> Message-ID: References: <20220917061328.8620-1-fantasquex@gmail.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: SVR-IES-MBX-08.mgc.mentorg.com (139.181.222.8) To svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) X-Spam-Status: No, score=-3111.1 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sat, 17 Sep 2022, Letu Ren via Libc-alpha wrote: > strfromf will convert the arguement with type float to double first. The *current implementation* will. That's not part of the specification, it's a quality-of-implementation bug (IEEE 754 leaves the presence of a sign for a NaN in the results of convertToDecimalCharacter and convertToHexCharacter optional, but glibc ought to be consistent here between types and architectures). That bug should be fixed; this patch should not be applied. -- Joseph S. Myers joseph@codesourcery.com