From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa3.mentor.iphmx.com (esa3.mentor.iphmx.com [68.232.137.180]) by sourceware.org (Postfix) with ESMTPS id 0ADA93858C2C for ; Mon, 3 Oct 2022 16:40:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0ADA93858C2C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.93,365,1654588800"; d="scan'208";a="83924442" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa3.mentor.iphmx.com with ESMTP; 03 Oct 2022 08:40:27 -0800 IronPort-SDR: /mrisgL8svxioZFzTUMtjqCi7pKez5QFD4yIs3PIxKDlg7HmXtYbckPKAbHQRLQ+n8ou2cpK37 vQuHdcub/19pqbPpobd59qY5rKWv8Gp+Xcpg705FUuEb/UbqDvJjERTWczCKNexP9gcLb3mBHe cqG6eLoo0efZljd82ZQBYJelBCKVKrIgEIdnvbxGIZ6rOIbxKltuzOlf9jk9BBkBAN32mlRXqw n8gN+4hvNquy8rLOqxRlgtBxlAiGlWGwJ4jtd2JYfrEv/zMKGLnnN8rQiQnBTpS8ro5HIONWg8 J8A= Date: Mon, 3 Oct 2022 16:40:22 +0000 From: Joseph Myers X-X-Sender: jsm28@digraph.polyomino.org.uk To: Adhemerval Zanella CC: , Fangrui Song , "H . J . Lu" , Noah Goldstein Subject: Re: [PATCH v2] x86: Remove .tfloat usage In-Reply-To: <20221003141802.281647-1-adhemerval.zanella@linaro.org> Message-ID: References: <20221003141802.281647-1-adhemerval.zanella@linaro.org> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) To svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) X-Spam-Status: No, score=-3110.9 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, 3 Oct 2022, Adhemerval Zanella via Libc-alpha wrote: > -factor: .tfloat ONE_SQR_CBRT2 > +factor: /* 1.0 / cbrt (2.0) ^ 2 / 0.629960524947436582364439673883 */ The comment here seems to be using "/" in two different ways, as a division operator and to separate two alternative descriptions of the constant. I think the latter should be "=", in this and the subsequent similar comments, to avoid confusion. -- Joseph S. Myers joseph@codesourcery.com