* [PATCH] linux: Fix syscall list generation instructions
@ 2020-07-09 4:40 Maciej W. Rozycki
2020-07-09 13:42 ` Alistair Francis
2020-07-09 15:08 ` Carlos O'Donell
0 siblings, 2 replies; 4+ messages in thread
From: Maciej W. Rozycki @ 2020-07-09 4:40 UTC (permalink / raw)
To: libc-alpha
Make the instructions for syscall list generation match Makefile and
refer to `update-syscall-lists'; there has been no `update-arch-syscall'
target. Also use single quotes around the command to stick to the ASCII
character set.
Fixes 4cf0d223052d ("Linux: Add tables with system call numbers").
---
As a fix to a Makefile comment only I trust it is fine to apply even in
the freeze period. OK to push then?
Maciej
---
sysdeps/unix/sysv/linux/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
glibc-update-syscall-lists.diff
Index: glibc/sysdeps/unix/sysv/linux/Makefile
===================================================================
--- glibc.orig/sysdeps/unix/sysv/linux/Makefile
+++ glibc/sysdeps/unix/sysv/linux/Makefile
@@ -26,7 +26,7 @@ ifndef subdir
# architecture-specific system call names.
#
# To bootstrap a new architecture, create an empty file in the right
-# place and run ?make update-arch-syscall? from the top-level of a
+# place and run `make update-syscall-lists' from the top-level of a
# configured, but not-yet-built glibc tree.
#
# --lock points to a file not replaced during the update operation, so
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] linux: Fix syscall list generation instructions
2020-07-09 4:40 [PATCH] linux: Fix syscall list generation instructions Maciej W. Rozycki
@ 2020-07-09 13:42 ` Alistair Francis
2020-07-09 15:08 ` Carlos O'Donell
1 sibling, 0 replies; 4+ messages in thread
From: Alistair Francis @ 2020-07-09 13:42 UTC (permalink / raw)
To: Maciej W. Rozycki; +Cc: GNU C Library
On Wed, Jul 8, 2020 at 9:40 PM Maciej W. Rozycki via Libc-alpha
<libc-alpha@sourceware.org> wrote:
>
> Make the instructions for syscall list generation match Makefile and
> refer to `update-syscall-lists'; there has been no `update-arch-syscall'
> target. Also use single quotes around the command to stick to the ASCII
> character set.
>
> Fixes 4cf0d223052d ("Linux: Add tables with system call numbers").
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Alistair
> ---
> As a fix to a Makefile comment only I trust it is fine to apply even in
> the freeze period. OK to push then?
>
> Maciej
> ---
> sysdeps/unix/sysv/linux/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> glibc-update-syscall-lists.diff
> Index: glibc/sysdeps/unix/sysv/linux/Makefile
> ===================================================================
> --- glibc.orig/sysdeps/unix/sysv/linux/Makefile
> +++ glibc/sysdeps/unix/sysv/linux/Makefile
> @@ -26,7 +26,7 @@ ifndef subdir
> # architecture-specific system call names.
> #
> # To bootstrap a new architecture, create an empty file in the right
> -# place and run ?make update-arch-syscall? from the top-level of a
> +# place and run `make update-syscall-lists' from the top-level of a
> # configured, but not-yet-built glibc tree.
> #
> # --lock points to a file not replaced during the update operation, so
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] linux: Fix syscall list generation instructions
2020-07-09 4:40 [PATCH] linux: Fix syscall list generation instructions Maciej W. Rozycki
2020-07-09 13:42 ` Alistair Francis
@ 2020-07-09 15:08 ` Carlos O'Donell
2020-07-09 16:47 ` Maciej W. Rozycki
1 sibling, 1 reply; 4+ messages in thread
From: Carlos O'Donell @ 2020-07-09 15:08 UTC (permalink / raw)
To: Maciej W. Rozycki, libc-alpha
On 7/9/20 12:40 AM, Maciej W. Rozycki wrote:
> Make the instructions for syscall list generation match Makefile and
> refer to `update-syscall-lists'; there has been no `update-arch-syscall'
> target. Also use single quotes around the command to stick to the ASCII
> character set.
>
> Fixes 4cf0d223052d ("Linux: Add tables with system call numbers").
> ---
> As a fix to a Makefile comment only I trust it is fine to apply even in
> the freeze period. OK to push then?
>
> Maciej
> ---
> sysdeps/unix/sysv/linux/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> glibc-update-syscall-lists.diff
> Index: glibc/sysdeps/unix/sysv/linux/Makefile
> ===================================================================
> --- glibc.orig/sysdeps/unix/sysv/linux/Makefile
> +++ glibc/sysdeps/unix/sysv/linux/Makefile
> @@ -26,7 +26,7 @@ ifndef subdir
> # architecture-specific system call names.
> #
> # To bootstrap a new architecture, create an empty file in the right
> -# place and run ?make update-arch-syscall? from the top-level of a
> +# place and run `make update-syscall-lists' from the top-level of a
> # configured, but not-yet-built glibc tree.
> #
> # --lock points to a file not replaced during the update operation, so
>
This is trivial and Allistair gave a reivew. Please commit if you haven't
already.
--
Cheers,
Carlos.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] linux: Fix syscall list generation instructions
2020-07-09 15:08 ` Carlos O'Donell
@ 2020-07-09 16:47 ` Maciej W. Rozycki
0 siblings, 0 replies; 4+ messages in thread
From: Maciej W. Rozycki @ 2020-07-09 16:47 UTC (permalink / raw)
To: Carlos O'Donell, Alistair Francis; +Cc: libc-alpha
On Thu, 9 Jul 2020, Carlos O'Donell wrote:
> > Index: glibc/sysdeps/unix/sysv/linux/Makefile
> > ===================================================================
> > --- glibc.orig/sysdeps/unix/sysv/linux/Makefile
> > +++ glibc/sysdeps/unix/sysv/linux/Makefile
> > @@ -26,7 +26,7 @@ ifndef subdir
> > # architecture-specific system call names.
> > #
> > # To bootstrap a new architecture, create an empty file in the right
> > -# place and run ?make update-arch-syscall? from the top-level of a
> > +# place and run `make update-syscall-lists' from the top-level of a
> > # configured, but not-yet-built glibc tree.
> > #
> > # --lock points to a file not replaced during the update operation, so
> >
>
> This is trivial and Allistair gave a reivew. Please commit if you haven't
> already.
Applied now; thank you both for the go-ahead!
Maciej
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-07-09 16:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-09 4:40 [PATCH] linux: Fix syscall list generation instructions Maciej W. Rozycki
2020-07-09 13:42 ` Alistair Francis
2020-07-09 15:08 ` Carlos O'Donell
2020-07-09 16:47 ` Maciej W. Rozycki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).