From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa5.hgst.iphmx.com (esa5.hgst.iphmx.com [216.71.153.144]) by sourceware.org (Postfix) with ESMTPS id 95DA13857C6A for ; Wed, 15 Jul 2020 00:32:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 95DA13857C6A IronPort-SDR: 78BOlsiR2d9uTIpRovxKPGcAdaUr/qZT0mzea1TzsWhxLYhtrlg/yc9iIHySvTAbYmc2j//wxR MhDxOeUhbrs/Afvt3OQKRDLvlygYvNnpb+aY/PsIJ++tp7kGFc1kBdXbaChn+ca/ncR1cGkH/b YE9sbwRCp8U3658b1olm+Q92ayfk3vOryU8xipCGyv+qN9LSbAP4KvbsKAub5WaWshCuK9qBjY v9BJE6pJgV8o0L6DrKpRIcsNTGkyhoehuJAyb+D3/YXo4g9xFW1XmzHQmxIx5F2sNr/rR4jKLu e3o= X-IronPort-AV: E=Sophos;i="5.75,353,1589212800"; d="scan'208";a="142612923" Received: from h199-255-45-14.hgst.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 15 Jul 2020 08:32:59 +0800 IronPort-SDR: /26GQZmGH+OFZtl38YP0FCBuKv5Rqb1DZDqiVmG8uJd+nBMhTgTquYZbRVunGBlfECtcVSSSqM LQaxdtwzorU0hP2tkVz4nAIo5kBVxW1iE= Received: from uls-op-cesaip01.wdc.com ([10.248.3.36]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jul 2020 17:21:24 -0700 IronPort-SDR: tzlX72tXil4I3rffsgmn1XSUUV71f9u1TaW1ZFY9L9ZG5c7D3v6RjBkJHf7KiX2pKGNj5jUMl6 5u832fU+WkRw== WDCIronportException: Internal Received: from unknown (HELO redsun52) ([10.149.66.28]) by uls-op-cesaip01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jul 2020 17:32:57 -0700 Date: Wed, 15 Jul 2020 01:32:53 +0100 (BST) From: "Maciej W. Rozycki" To: Alistair Francis cc: libc-alpha@sourceware.org Subject: Re: [PATCH v3 17/19] RISC-V: Add rv32 path to RTLDLIST in ldd In-Reply-To: <3b9e6dd8baa53076ea5019f1e18d770ea47b58bb.1594568655.git.alistair.francis@wdc.com> Message-ID: References: <3b9e6dd8baa53076ea5019f1e18d770ea47b58bb.1594568655.git.alistair.francis@wdc.com> User-Agent: Alpine 2.21 (LFD 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-10.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Jul 2020 00:33:00 -0000 On Sun, 12 Jul 2020, Alistair Francis via Libc-alpha wrote: > diff --git a/sysdeps/unix/sysv/linux/riscv/ldd-rewrite.sed b/sysdeps/unix/sysv/linux/riscv/ldd-rewrite.sed > index 377a9c6ef4..bc0c4f51a1 100644 > --- a/sysdeps/unix/sysv/linux/riscv/ldd-rewrite.sed > +++ b/sysdeps/unix/sysv/linux/riscv/ldd-rewrite.sed > @@ -1 +1 @@ > -s_^\(RTLDLIST=\)\(.*lib/\)\(ld-linux\)-\(riscv64\)-\(lp64\)\(d*\)\(\.so\.[0-9.]*\)_\1"\2\3-\4-\5\7 \2\3-\4-\5d\7"_ > +s_^\(RTLDLIST=\)\(.*lib\)\(/[^/]*\)\(64\|32\)\(-.*\)\(lp\)\(64\|32\)\(d*\)\(\.so\.[0-9.]*\)[ ]*$_\1"\2\364-\664\9 \2\364-\664\8\9 \2\332-i\632\9 \2\332-i\632\8\9"_ This doesn't seem right to me. Currently the list produced is as follows: RTLDLIST="/lib/ld-linux-riscv64-lp64.so.1 /lib/ld-linux-riscv64-lp64d.so.1" regardless of whether the ABI configured for has been lp64 or lp64d. With this change in place the list becomes ABI specific and is: RTLDLIST="/lib/ld-linux-riscv64-lp64.so.1 /lib/ld-linux-riscv64-lp64.so.1 /lib/ld-linux-riscv32-ilp32.so.1 /lib/ld-linux-riscv32-ilp32.so.1" -- for the ilp32 or lp64 ABIs, and: RTLDLIST="/lib/ld-linux-riscv64-lp64.so.1 /lib/ld-linux-riscv64-lp64d.so.1 /lib/ld-linux-riscv32-ilp32.so.1 /lib/ld-linux-riscv32-ilp32d.so.1" -- for the ilp32d or lp64d ABIs. Please look into it. Maciej