From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa5.hgst.iphmx.com (esa5.hgst.iphmx.com [216.71.153.144]) by sourceware.org (Postfix) with ESMTPS id DD1123842400 for ; Thu, 16 Jul 2020 00:24:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org DD1123842400 IronPort-SDR: RncqMKo2V95d/WRTkSyitK48v9hHhn0xhdJYVzTpS0sjjAKcnl0LDtx1ZVwBBhzGm7t+TRTO56 1PtPChcAzeow7+5JjBqJ8r4lwFs+ype+79W7rNUku5/v/osnTIUPoc8+CbG7Kf1xLTpB5NBVJS ZgEiZ4LyupMZcSR3XJ4BIB1eFuKguy8zQ23DrPdRe9Hc3Qu9GM+R0wxb9TcZXcCzfilnHjwbrk zMWy83c/Neap7e6/p5GOyqovNV0ZWYI3XiCCQM5HGYkMSotgwWm/Bln3aJ1gWZQ/P+qzEWS40L nmU= X-IronPort-AV: E=Sophos;i="5.75,357,1589212800"; d="scan'208";a="142696853" Received: from h199-255-45-14.hgst.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 16 Jul 2020 08:23:28 +0800 IronPort-SDR: ZOyY2lVtXDBzgH0Oln0v/bcYUbly+mTmkKHdynm3yerW2e8GLtPu/a0QfAOjRDMDp4VvTChlOC a+vfoMit9Y77XmgbVvDYEPlwZu8CO/55g= Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jul 2020 17:11:51 -0700 IronPort-SDR: 34h1+9XDgU+o27f4dPdXg9iKBzMdtjwRejgjBNplBoxZsDVHGyTe5Dv2nX+G7epmUCt4CxQB0k DUQfrIO1IUrQ== WDCIronportException: Internal Received: from unknown (HELO redsun52) ([10.149.66.28]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jul 2020 17:23:26 -0700 Date: Thu, 16 Jul 2020 01:23:23 +0100 (BST) From: "Maciej W. Rozycki" To: Adhemerval Zanella cc: Alistair Francis , libc-alpha@sourceware.org Subject: Re: [PATCH v2 02/18] RISC-V: Define __NR_* as __NR_*_time64/64 for 32-bit In-Reply-To: Message-ID: References: <56ade7ab382535b83feb14058df9a84aad0dcaac.1591201405.git.alistair.francis@wdc.com> User-Agent: Alpine 2.21 (LFD 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-10.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Jul 2020 00:24:20 -0000 [Added cc's back.] On Wed, 8 Jul 2020, Adhemerval Zanella via Libc-alpha wrote: > >> diff --git a/sysdeps/unix/sysv/linux/riscv/sysdep.h b/sysdeps/unix/sysv/linux/riscv/sysdep.h > >> index 83e4adf6a2..aa61e8b04d 100644 > >> --- a/sysdeps/unix/sysv/linux/riscv/sysdep.h > >> +++ b/sysdeps/unix/sysv/linux/riscv/sysdep.h > >> @@ -116,6 +116,67 @@ > >> > >> #include > > > > This file is weird, as it includes twice, first > > time indirectly via at the top, > > and then second time here. So I think this second inclusion can be > > removed (along with the preceding inclusion of , as it does not > > appear to change anything), and the following conditional moved to the > > top, just after the inclusion of . Oddly > > has not been protected against multiple inclusion, but its contents do not > > trigger compilation warnings if processed more than once. > > This multiple inclusion is done internally in some places so the file > that wants to override a definition would first include the generic > definitions and then #undef/#define the new one (kernel-features.h > still does it). > > I think this is kind of confusing, but this is how sysdep.h is currently > organized. We have been changing bit per bit, but there is a lot of > place where inclusing is done without guards. Fair enough, however the RISC-V port does not appear to make use of it as the removal of the second inclusion does not change anything (I actually double-checked). Maciej