From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa2.hgst.iphmx.com (esa2.hgst.iphmx.com [68.232.143.124]) by sourceware.org (Postfix) with ESMTPS id 6D7893850401 for ; Thu, 16 Jul 2020 01:07:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 6D7893850401 IronPort-SDR: R2Man6yp7CmFx77iFhAnqLLN67Ey/lyLywzpApUJA66wkWjpiglJ6XwalhOi2BFEivM0L0NFbQ pu06Bc/Lly61PWa5QYWdQoOu2hhsRFgXUyEFiHJLCTTW4bpPo39atjoVOiU5gIyWz6/tcRp+2V Cm7OgmsOqHLipOAFY7s4KmEuuoBMnw75McIr7ajl0r7HkCr731H+iTi2VhAlrd8muc0Mqz7F5m P/JywcJzhRt8QdqBjFnWxq0w2CSJc2nLjBQfrMwAKqbj1gLEiHHq3cRS32b+RiJp/MzSU0/lld rrs= X-IronPort-AV: E=Sophos;i="5.75,357,1589212800"; d="scan'208";a="245598993" Received: from h199-255-45-14.hgst.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 16 Jul 2020 09:07:55 +0800 IronPort-SDR: g2a4XhplQhOLh5OHfgr0QAf6N6TgaTntOv4q3817kbMz3rXVDRCwxQCCkZKrYsUwZY4Z8Cl3R9 SokWBTX6a4DUMnMwqI0YyYCIH5WYP3Hjw= Received: from uls-op-cesaip01.wdc.com ([10.248.3.36]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jul 2020 17:56:00 -0700 IronPort-SDR: FrM9BKX+mVJZnHbfBkw743qpz4TojuY8LxZNudeCheW0Lm8o7KA5pZxcYCmr7gHNEQUb4FVHO/ SSnS9Fth0yOw== WDCIronportException: Internal Received: from unknown (HELO redsun52) ([10.149.66.28]) by uls-op-cesaip01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jul 2020 18:07:35 -0700 Date: Thu, 16 Jul 2020 02:07:31 +0100 (BST) From: "Maciej W. Rozycki" To: Alistair Francis cc: libc-alpha@sourceware.org Subject: Re: [PATCH v3 02/19] RISC-V: Cleanup some of the sysdep.h code In-Reply-To: <91a2de374c9ae48869743324f4a0edc185f63161.1594568655.git.alistair.francis@wdc.com> Message-ID: References: <91a2de374c9ae48869743324f4a0edc185f63161.1594568655.git.alistair.francis@wdc.com> User-Agent: Alpine 2.21 (LFD 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-10.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Jul 2020 01:07:39 -0000 On Sun, 12 Jul 2020, Alistair Francis via Libc-alpha wrote: > --- > sysdeps/unix/sysv/linux/riscv/sysdep.h | 14 +------------- > 1 file changed, 1 insertion(+), 13 deletions(-) Please try to have at least a little explanation for posterity with non-mechanical changes like this, e.g.: Remove a duplicate inclusion of which is already pulled via , and the inclusion of whose definition of `__set_errno' is not needed here. It's not always easy for the reader to reproduce an environment needed to bring the observations that have lead to the conclusion a given change is the right one to make; they shouldn't have to anyway. > diff --git a/sysdeps/unix/sysv/linux/riscv/sysdep.h b/sysdeps/unix/sysv/linux/riscv/sysdep.h > index 83e4adf6a2..429686cebe 100644 > --- a/sysdeps/unix/sysv/linux/riscv/sysdep.h > +++ b/sysdeps/unix/sysv/linux/riscv/sysdep.h > @@ -107,19 +107,7 @@ > # undef ret_ERRVAL > # define ret_ERRVAL ret > > -#endif /* __ASSEMBLER__ */ > - > -/* In order to get __set_errno() definition in INLINE_SYSCALL. */ > -#ifndef __ASSEMBLER__ > -# include > -#endif > - > -#include > - > -#undef SYS_ify > -#define SYS_ify(syscall_name) __NR_##syscall_name This redefinition actually has to stay; sorry to be unclear about it. I can see you have readded it with 03/19, but having things broken even for the duration of a single commit will interfere with bisection. Please place it after the common inclusions at the top of this file. Maciej