From: "Maciej W. Rozycki" <macro@wdc.com>
To: Alistair Francis <alistair.francis@wdc.com>,
Carlos O'Donell <carlos@redhat.com>
Cc: libc-alpha@sourceware.org, alistair23@gmail.com
Subject: Re: [PATCH v4 02/18] RISC-V: Cleanup some of the sysdep.h code
Date: Mon, 17 Aug 2020 14:53:09 +0100 (BST) [thread overview]
Message-ID: <alpine.LFD.2.21.2008171439480.24175@redsun52.ssa.fujisawa.hgst.com> (raw)
In-Reply-To: <c1e18d8cf073268918f93bff10b44519333625c0.1597243100.git.alistair.francis@wdc.com>
On Wed, 12 Aug 2020, Alistair Francis wrote:
> diff --git a/sysdeps/unix/sysv/linux/riscv/sysdep.h b/sysdeps/unix/sysv/linux/riscv/sysdep.h
> index 83e4adf6a2..fbc2436691 100644
> --- a/sysdeps/unix/sysv/linux/riscv/sysdep.h
> +++ b/sysdeps/unix/sysv/linux/riscv/sysdep.h
[...]
> @@ -107,19 +110,7 @@
> # undef ret_ERRVAL
> # define ret_ERRVAL ret
>
> -#endif /* __ASSEMBLER__ */
> -
> -/* In order to get __set_errno() definition in INLINE_SYSCALL. */
> -#ifndef __ASSEMBLER__
> -# include <errno.h>
> -#endif
> -
> -#include <sysdeps/unix/sysdep.h>
> -
> -#undef SYS_ify
> -#define SYS_ify(syscall_name) __NR_##syscall_name
> -
> -#ifndef __ASSEMBLER__
> +#else
Please comment #else:
#else /* !__ASSEMBLER__ */
especially as the conditional part above is very long. Otherwise OK.
This is not actually mentioned in our coding style document, unlike
#endif, giving an impression we don't want #else statements commented:
<https://sourceware.org/glibc/wiki/Style_and_Conventions#Commenting_.23endif>.
This is however covered by the generic GNU Coding Standards document:
<https://www.gnu.org/prep/standards/standards.html#Comments>.
Carlos: Do we want our wiki updated here? ISTM we should. WDYT?
Maciej
next prev parent reply other threads:[~2020-08-17 13:53 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-12 14:40 [PATCH v4 00/18] glibc port for 32-bit RISC-V (RV32) Alistair Francis
2020-08-12 14:40 ` [PATCH v4 01/18] RISC-V: Use 64-bit time_t and off_t for RV32 and RV64 Alistair Francis
2020-08-12 14:40 ` [PATCH v4 02/18] RISC-V: Cleanup some of the sysdep.h code Alistair Francis
2020-08-17 13:53 ` Maciej W. Rozycki [this message]
2020-08-18 17:37 ` Carlos O'Donell
2020-08-21 17:13 ` Maciej W. Rozycki
2020-08-12 14:40 ` [PATCH v4 03/18] RISC-V: Use 64-bit-time syscall numbers with the 32-bit port Alistair Francis
2020-08-17 14:07 ` Maciej W. Rozycki
2020-08-12 14:40 ` [PATCH v4 04/18] RISC-V: Add support for 32-bit vDSO calls Alistair Francis
2020-08-17 14:10 ` Maciej W. Rozycki
2020-08-18 1:35 ` Kito Cheng
2020-08-12 14:41 ` [PATCH v4 05/18] RISC-V: Support dynamic loader for the 32-bit Alistair Francis
2020-08-12 14:41 ` [PATCH v4 07/18] sysv/linux: riscv: Fix dl-cache.h indentation Alistair Francis
2020-08-17 14:21 ` Maciej W. Rozycki
2020-08-12 14:41 ` [PATCH v4 08/18] RISC-V: Add arch-syscall.h for RV32 Alistair Francis
2020-08-12 17:38 ` Joseph Myers
2020-08-12 18:14 ` Alistair Francis
2020-08-12 14:41 ` [PATCH v4 09/18] RISC-V: Support the 32-bit ABI implementation Alistair Francis
2020-08-18 13:35 ` Maciej W. Rozycki
2020-08-12 14:41 ` [PATCH v4 10/18] RISC-V: Hard float support for 32-bit Alistair Francis
2020-08-18 14:37 ` Maciej W. Rozycki
2020-08-12 14:41 ` [PATCH v4 11/18] RISC-V: Add 32-bit ABI lists Alistair Francis
2020-08-18 14:42 ` Maciej W. Rozycki
2020-08-12 14:41 ` [PATCH v4 12/18] RISC-V: Add the RV32 libm-test-ulps Alistair Francis
2020-08-18 15:06 ` Maciej W. Rozycki
2020-08-18 15:02 ` Alistair Francis
2020-08-12 14:41 ` [PATCH v4 13/18] RISC-V: Fix llrint and llround missing exceptions on RV32 Alistair Francis
2020-08-18 15:09 ` Maciej W. Rozycki
2020-08-12 14:41 ` [PATCH v4 14/18] riscv32: Specify the arch_minimum_kernel as 5.4 Alistair Francis
2020-08-18 16:43 ` Maciej W. Rozycki
2020-08-12 14:41 ` [PATCH v4 16/18] RISC-V: Add rv32 path to RTLDLIST in ldd Alistair Francis
2020-08-18 23:52 ` Maciej W. Rozycki
2020-08-12 14:42 ` [PATCH v4 17/18] Documentation for the RISC-V 32-bit port Alistair Francis
2020-08-18 23:59 ` Maciej W. Rozycki
2020-08-12 14:42 ` [PATCH v4 18/18] Add RISC-V 32-bit target to build-many-glibcs.py Alistair Francis
2020-08-19 0:00 ` Maciej W. Rozycki
2020-08-12 17:37 ` [PATCH v4 00/18] glibc port for 32-bit RISC-V (RV32) Joseph Myers
2020-08-13 14:59 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.21.2008171439480.24175@redsun52.ssa.fujisawa.hgst.com \
--to=macro@wdc.com \
--cc=alistair.francis@wdc.com \
--cc=alistair23@gmail.com \
--cc=carlos@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).