From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa1.hgst.iphmx.com (esa1.hgst.iphmx.com [68.232.141.245]) by sourceware.org (Postfix) with ESMTPS id 96CF93857C4D for ; Tue, 18 Aug 2020 15:06:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 96CF93857C4D IronPort-SDR: 7m8S4c0e7vPi+JRi3YQq+PqOrpBU2f8/pEF1JkA25OMK2wNUAo1+5hIvdrImJeDn2L2Q70OjLm 4NB7p88ayDh+eYQvAGR48+0lNo6tAFKeMPkjdaRmCajaYweNRoz4aX0BdtXZ4MSD4PMcdjhj6W 2QKJZ4JZrbcB908ZEa91PoWXRCWne4Y2YfS078DTO2GyUWBiLu2wE1+kHjT3G8ySD4kmyVA/H9 IkCQ2R7lETE4xA7ObPM/o5uc2J6T5W3Sp5VOqpLB9D5OC91zDRiIqX4wBjYjlsfP3UBQyAY0Gk d8A= X-IronPort-AV: E=Sophos;i="5.76,327,1592841600"; d="scan'208";a="254655985" Received: from h199-255-45-15.hgst.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 18 Aug 2020 23:06:11 +0800 IronPort-SDR: vlzSKsD9WbKk7ex3MrEvrNf2J2zjod9NT0AoKck+MJdpdsWyiFKWmA4yUxTg1b1qtTGnEtC+oV wNRj4JdL7wAg== Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Aug 2020 07:53:10 -0700 IronPort-SDR: hkU3xQGT/uSQdr+WMbCCrzaPnMD+0T1JnrGLqDvgKaSSwhCjvFLZBQoOM487MAsfjNlWQxaSPf IFUw3Cp143BQ== WDCIronportException: Internal Received: from unknown (HELO redsun52) ([10.149.66.28]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Aug 2020 08:06:10 -0700 Date: Tue, 18 Aug 2020 16:06:05 +0100 (BST) From: "Maciej W. Rozycki" To: Alistair Francis cc: libc-alpha@sourceware.org, alistair23@gmail.com Subject: Re: [PATCH v4 12/18] RISC-V: Add the RV32 libm-test-ulps In-Reply-To: <51761c15e515eb8c90be7312454198454f59c0cd.1597243100.git.alistair.francis@wdc.com> Message-ID: References: <51761c15e515eb8c90be7312454198454f59c0cd.1597243100.git.alistair.francis@wdc.com> User-Agent: Alpine 2.21 (LFD 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Aug 2020 15:06:15 -0000 On Wed, 12 Aug 2020, Alistair Francis wrote: > Add a libm-test-ulps for RV32, this is the same as the RV64 one. > > This dosn't match what is generated by running `make regen-ulps` on RV32 > QEMU, but the current in tree RV64 doesn't match that either. The differences have been discussed from: on, and the course of action to track the origin down specifically here: . Given the proposed change makes RV32 ulps identical to RV64 ones this patch looks good to me. The differences between hardware and QEMU results are irrelevant to RV32 support and need to be sorted separately. Reviewed-by: Maciej W. Rozycki Maciej