From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa3.hgst.iphmx.com (esa3.hgst.iphmx.com [216.71.153.141]) by sourceware.org (Postfix) with ESMTPS id 6FF60384605A for ; Tue, 18 Aug 2020 15:09:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 6FF60384605A IronPort-SDR: soU+nRy/dn16C231F5E60bBhwmfgIuDJdkMIA7vX8NrihQ8SgZFZcB9JF9xk9YW7n6Zec4Kg72 IF+r+LotamdX3FMPB6PklUo/u/PD7Uo3jWnxnUEa2i5mwODLSJD++M9nykTiBxnHb4KIIKWSFX h5m+/jHuKKdjXjpOXESTVqL/bzSsJphqdofZ8aWZ9j0ppK8fEpi0X6gJwFK2G3qwJpfsJcBnqW C6dsrsu6+ITP9SUqaNCwDEthd+F9hjwXJnURVGrXpLdYrTeLLu4Ce8sN3PebU/MjCHUE3/wNIx YI4= X-IronPort-AV: E=Sophos;i="5.76,327,1592841600"; d="scan'208";a="149557635" Received: from h199-255-45-14.hgst.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 18 Aug 2020 23:09:41 +0800 IronPort-SDR: oUeIZvo2fbJRCUYnN56HicVXKliVOYavWX5jeVgQTvj/QprOsALpBvDJvoFB7j1fKnyLVYUC85 JxBp9aOX5eHw== Received: from uls-op-cesaip01.wdc.com ([10.248.3.36]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Aug 2020 07:57:25 -0700 IronPort-SDR: M/GWw+P7wR+lsbvV7OpZmkDyd0YKsxDNhxIzhP7v0zuUDhiNBMIYy539iTbfkLPWRH5jfUzxCh o3/k/vzjNUyA== WDCIronportException: Internal Received: from unknown (HELO redsun52) ([10.149.66.28]) by uls-op-cesaip01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Aug 2020 08:09:41 -0700 Date: Tue, 18 Aug 2020 16:09:37 +0100 (BST) From: "Maciej W. Rozycki" To: Alistair Francis cc: libc-alpha@sourceware.org, alistair23@gmail.com Subject: Re: [PATCH v4 13/18] RISC-V: Fix llrint and llround missing exceptions on RV32 In-Reply-To: Message-ID: References: User-Agent: Alpine 2.21 (LFD 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_NUMSUBJECT, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Aug 2020 15:09:43 -0000 On Wed, 12 Aug 2020, Alistair Francis wrote: > Conversions from a float to a long long on 32-bit RISC-V (RV32) may not > raise the correct exceptions on overflow, it also may raise spurious > "inexact" exceptions on non overflow cases. This patch fixes the ^ Missing space here. > problem, similary to the fix for MIPS, ARM and S390. s/similary/similarly/ Otherwise OK. Maciej