From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa2.hgst.iphmx.com (esa2.hgst.iphmx.com [68.232.143.124]) by sourceware.org (Postfix) with ESMTPS id 58CA43858D38 for ; Tue, 18 Aug 2020 23:52:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 58CA43858D38 IronPort-SDR: GHSXU4SoldAeQJV7CT+bv+wK5DwgO96NOHvJp2iPUfR9DFi6EoHohuql0+PaB3jZRXcgqrWE4B dzHN2/1hM3RJ17O6c4bB/0szRfcG76aISk3qlq3F0KLElMQpC4++geVY+ZfaNOmeTvBz6Zn6Tm 8Q+fg25LbnZzLSmikEEdaBqJCA/uIIzxrKdRmuL/mIWuC917P1BQOpTjE4daNiPnhkTd4lBMgB NHaalHoQeaTq0DwfqMuH9Umcz5lcCKYmvNlLx0ZA3qpuyV2FKaotrsxegc0VwKs35HkT4a2VWn M54= X-IronPort-AV: E=Sophos;i="5.76,329,1592841600"; d="scan'208";a="248445360" Received: from h199-255-45-14.hgst.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 19 Aug 2020 07:53:09 +0800 IronPort-SDR: D9MOz/tSI7RcPtwjDkSpgVRZNHIl0Xykxuf02x2fB9/eMPT+hrG0MzIWEQLSniGDLVM9KSWlQv QVk35T6bW1Qg== Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Aug 2020 16:40:35 -0700 IronPort-SDR: jkokQIIkRTSMaztGUMJR8mcO6MKxk5FpdgF2N7XONNseSQvsShJIS7ZutADzGyWs3YjTUpI4OP AUzUroOFxh1Q== WDCIronportException: Internal Received: from unknown (HELO redsun52) ([10.149.66.28]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Aug 2020 16:52:50 -0700 Date: Wed, 19 Aug 2020 00:52:45 +0100 (BST) From: "Maciej W. Rozycki" To: Alistair Francis cc: libc-alpha@sourceware.org, alistair23@gmail.com Subject: Re: [PATCH v4 16/18] RISC-V: Add rv32 path to RTLDLIST in ldd In-Reply-To: <703af27797ca64c90c3c6103454fba4dc4ac34b9.1597243100.git.alistair.francis@wdc.com> Message-ID: References: <703af27797ca64c90c3c6103454fba4dc4ac34b9.1597243100.git.alistair.francis@wdc.com> User-Agent: Alpine 2.21 (LFD 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-10.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Aug 2020 23:52:53 -0000 On Wed, 12 Aug 2020, Alistair Francis wrote: > sysdeps/unix/sysv/linux/riscv/ldd-rewrite.sed | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Again there is a hole in numbering here and v3's 15/19, which I requested to come after this change, is missing. > diff --git a/sysdeps/unix/sysv/linux/riscv/ldd-rewrite.sed b/sysdeps/unix/sysv/linux/riscv/ldd-rewrite.sed > index 377a9c6ef4..0b26352c21 100644 > --- a/sysdeps/unix/sysv/linux/riscv/ldd-rewrite.sed > +++ b/sysdeps/unix/sysv/linux/riscv/ldd-rewrite.sed > @@ -1 +1 @@ > -s_^\(RTLDLIST=\)\(.*lib/\)\(ld-linux\)-\(riscv64\)-\(lp64\)\(d*\)\(\.so\.[0-9.]*\)_\1"\2\3-\4-\5\7 \2\3-\4-\5d\7"_ > +s_^\(RTLDLIST=\)\(.*lib\)\(/[^/]*\)\(64\|32\)\(-.*\)\(lp\)\(64\|32\)\(d*\)\(\.so\.[0-9.]*\)[ ]*$_\1"\2\364-\664\9 \2\364-\664d\9 \2\332-i\632\9 \2\332-i\632d\9"_ Ah, thanks for tracking down the problem here. This however caused that \8 is not used anymore, so how about: s_^\(RTLDLIST=\)\(.*lib\)\(/[^/]*\)\(64\|32\)\(-.*\)\(lp\)\(64\|32\)d*\(\.so\.[0-9.]*\)[ ]*$_\1"\2\364-\664\8 \2\364-\664d\8 \2\332-i\632\8 \2\332-i\632d\8"_ (note that I fixed up an extraneous repeated space in `[ ]' too)? Maciej