From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa1.hgst.iphmx.com (esa1.hgst.iphmx.com [68.232.141.245]) by sourceware.org (Postfix) with ESMTPS id 481F93857C47 for ; Fri, 21 Aug 2020 17:13:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 481F93857C47 IronPort-SDR: 28Yp+QStHlMTj0MzTdcqlNMABA16y6hdI9ILq9OHhv4i+V/xjG74DZDdjysbJspkQaRo/dRGS9 vPAiMc6NvUXQZttFZMd4qblezzK2iJf5Jt9cjVXEAh/kl8OYEcXCU5E86KPdKI/ALuadwzMZ5R NeE1vsm/SQZr+y/di9Xz3eAX0wz3C92MUxTVoUQCl/9d2UhAdSkeJtobi1jo4xxdgUYpDSTpj5 vzTm5/xtXvz03ZscechPbedVpvVmUCTsmSPpzS3YEumwQx8c9B1HbK59lIlmsJu4tnwq4M8qxT DN8= X-IronPort-AV: E=Sophos;i="5.76,338,1592841600"; d="scan'208";a="254990719" Received: from h199-255-45-15.hgst.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 22 Aug 2020 01:13:16 +0800 IronPort-SDR: PIDJTlQ/3QRwsrmwg8s3/eHbxQMNO3QusEtLEjyxFmljYykylQ91vcZqq2m8VoiAy1/HK9SPxH A3NzfLsieFQg== Received: from uls-op-cesaip01.wdc.com ([10.248.3.36]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Aug 2020 10:00:10 -0700 IronPort-SDR: 71so2hXEPtJ3gr5XkdKloGzb7WHTZYSoNfoy7XlyOJFITRBFDSrJf8td5DPYvDS+4SElG4i4iY KYSZ0dC7oV2w== WDCIronportException: Internal Received: from unknown (HELO redsun52) ([10.149.66.28]) by uls-op-cesaip01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Aug 2020 10:13:15 -0700 Date: Fri, 21 Aug 2020 18:13:10 +0100 (BST) From: "Maciej W. Rozycki" To: Carlos O'Donell cc: Alistair Francis , libc-alpha@sourceware.org, alistair23@gmail.com Subject: Re: [PATCH v4 02/18] RISC-V: Cleanup some of the sysdep.h code In-Reply-To: Message-ID: References: User-Agent: Alpine 2.21 (LFD 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_SHORT, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Aug 2020 17:13:19 -0000 On Tue, 18 Aug 2020, Carlos O'Donell wrote: > > Please comment #else: > > > > #else /* !__ASSEMBLER__ */ > > > > especially as the conditional part above is very long. Otherwise OK. > > > > This is not actually mentioned in our coding style document, unlike > > #endif, giving an impression we don't want #else statements commented: > > . > > This is however covered by the generic GNU Coding Standards document: > > . > > > > Carlos: Do we want our wiki updated here? ISTM we should. WDYT? > > Yes! > > The GNU Coding Standard explains that we should comment #else, but doesn't > say what kind of comment should be used, and that content is up to the > project. > > The section should cover how glibc is unique and what we expect from the > #else comment. > > Your suggestion looks good to me. I have updated the wiki then, thank you for your opinion. Also we don't explicitly mention #elif, but I think it can be implied that the convention followed for conditional parts beyond that directive is the same as with plain #if. Maciej