From: "Maciej W. Rozycki" <macro@wdc.com>
To: Alistair Francis <alistair23@gmail.com>
Cc: Alistair Francis <alistair.francis@wdc.com>,
GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH v5 00/17] glibc port for 32-bit RISC-V (RV32)
Date: Wed, 26 Aug 2020 17:06:53 +0100 (BST) [thread overview]
Message-ID: <alpine.LFD.2.21.2008252224120.24175@redsun52.ssa.fujisawa.hgst.com> (raw)
In-Reply-To: <CAKmqyKOvwV+TgYS33zNcHk6hD+dkBw2+26+Ey26DSHZkfz5P1g@mail.gmail.com>
On Tue, 25 Aug 2020, Alistair Francis wrote:
> > > io/tst-lockf.out
> > > error: subprocess failed: lockf
> > > error: unexpected output from subprocess
> > > tst-lockf.c:49: numeric comparison failure
> > > left: 0 (0x0); from: lockf (temp_fd, F_TEST, 1024)
> > > right: -1 (0xffffffff); from: -1
> > > error: 2 test failures
> >
> > This might be more interesting to look into further; as `len' is of the
> > `off_t' type it would be good to double-check it is correctly handled.
>
> I have fixed this as well, the test is incorrectly calling the lockf()
> function (not 64-bit version). I'll send a patch.
Shouldn't `lockf' and `lockf64' be aliases to each other on RV32? IOW do
we support a non-LFS environment at all?
(Of course the test case may still require an adjustment as it seems to
imply non-LFS support to be present, i.e.:
/* Check if non-LFS interface cap access to 32-bif off_t. */
TEST_COMPARE (lseek64 (temp_fd, (off64_t)INT32_MAX, SEEK_SET),
(off64_t)INT32_MAX);
though I find it odd as 64-bit targets starting from DEC Alpha have never
had it.)
Maciej
next prev parent reply other threads:[~2020-08-26 16:07 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-19 15:38 Alistair Francis
2020-08-19 15:38 ` [PATCH v5 01/17] RISC-V: Use 64-bit time_t and off_t for RV32 and RV64 Alistair Francis
2020-08-19 15:38 ` [PATCH v5 02/17] RISC-V: Cleanup some of the sysdep.h code Alistair Francis
2020-08-20 21:35 ` Maciej W. Rozycki
2020-08-19 15:38 ` [PATCH v5 03/17] RISC-V: Use 64-bit-time syscall numbers with the 32-bit port Alistair Francis
2020-08-20 21:39 ` Maciej W. Rozycki
2020-08-19 15:38 ` [PATCH v5 04/17] RISC-V: Add support for 32-bit vDSO calls Alistair Francis
2020-08-19 15:38 ` [PATCH v5 05/17] RISC-V: Support dynamic loader for the 32-bit Alistair Francis
2020-08-19 15:38 ` [PATCH v5 06/17] RISC-V: Add path of library directories " Alistair Francis
2020-08-21 11:16 ` Maciej W. Rozycki
2020-08-19 15:38 ` [PATCH v5 07/17] RISC-V: Add arch-syscall.h for RV32 Alistair Francis
2020-08-19 15:38 ` [PATCH v5 08/17] RISC-V: Support the 32-bit ABI implementation Alistair Francis
2020-08-21 11:21 ` Maciej W. Rozycki
2020-08-19 15:39 ` [PATCH v5 09/17] RISC-V: Add hard float support for 32-bit CPUs Alistair Francis
2020-08-21 11:23 ` Maciej W. Rozycki
2020-08-19 15:39 ` [PATCH v5 10/17] RISC-V: Add 32-bit ABI lists Alistair Francis
2020-08-21 11:32 ` Maciej W. Rozycki
2020-08-19 15:39 ` [PATCH v5 11/17] RISC-V: Add the RV32 libm-test-ulps Alistair Francis
2020-08-19 15:39 ` [PATCH v5 12/17] RISC-V: Fix llrint and llround missing exceptions on RV32 Alistair Francis
2020-08-21 11:36 ` Maciej W. Rozycki
2020-08-19 15:39 ` [PATCH v5 13/17] riscv32: Specify the arch_minimum_kernel as 5.4 Alistair Francis
2020-08-21 11:38 ` Maciej W. Rozycki
2020-08-19 15:39 ` [PATCH v5 14/17] RISC-V: Add rv32 path to RTLDLIST in ldd Alistair Francis
2020-08-21 11:43 ` Maciej W. Rozycki
2020-08-19 15:39 ` [PATCH v5 15/17] RISC-V: Build infastructure for 32-bit port Alistair Francis
2020-08-21 11:59 ` Maciej W. Rozycki
2020-08-21 15:22 ` Alistair Francis
2020-08-19 15:39 ` [PATCH v5 16/17] Documentation for the RISC-V " Alistair Francis
2020-08-21 11:59 ` Maciej W. Rozycki
2020-08-19 15:39 ` [PATCH v5 17/17] Add RISC-V 32-bit target to build-many-glibcs.py Alistair Francis
2020-08-20 13:11 ` [PATCH v5 00/17] glibc port for 32-bit RISC-V (RV32) Maciej W. Rozycki
2020-08-21 15:25 ` Alistair Francis
2020-08-22 13:04 ` Maciej W. Rozycki
2020-08-22 13:44 ` Andreas Schwab
2020-08-24 17:18 ` Alistair Francis
2020-08-24 18:17 ` Maciej W. Rozycki
2020-08-25 18:15 ` Alistair Francis
2020-08-26 16:06 ` Maciej W. Rozycki [this message]
2020-08-26 1:15 ` Nelson Chu
2020-08-26 15:43 ` Alistair Francis
2020-08-29 21:41 ` Maciej W. Rozycki
2020-08-28 18:19 ` Joseph Myers
2020-08-24 22:41 ` Joseph Myers
2020-08-25 18:20 ` Alistair Francis
2020-08-20 22:37 ` Alistair Francis
2020-08-21 15:43 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.21.2008252224120.24175@redsun52.ssa.fujisawa.hgst.com \
--to=macro@wdc.com \
--cc=alistair.francis@wdc.com \
--cc=alistair23@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).