public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Alexander Monakov <amonakov@ispras.ru>
To: Rogerio Alves <rcardoso@linux.vnet.ibm.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [RFC] powerpc: restore TOC when static longjmp to shared object
Date: Wed, 23 May 2018 09:27:00 -0000	[thread overview]
Message-ID: <alpine.LNX.2.20.13.1805231219280.27433@monopod.intra.ispras.ru> (raw)
In-Reply-To: <4c67a306-d447-1158-1b92-22ed1cfcfa0a@linux.vnet.ibm.com>

On Tue, 22 May 2018, Rogerio Alves wrote:

> I've attached patch v2 to this email with the fixes suggested by Adhemerval.

Why was it necessary to change the prototype of lbar(), and does the testcase
still demonstrate the issue with that change (does it fail without the patch)?

Note that as soon as gcc is capable of optimizing out the alloca-memset code
in the testcase, it will no longer serve the purpose (maybe it's already
capable, when preparing the testcase I only checked -O0 IIRC). Surely there
are more direct and robust ways of checking that TOC is correctly restored?

Alexander

  reply	other threads:[~2018-05-23  9:27 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <f88767a0-1a38-564d-7bd8-0b5db5bc04df@linux.vnet.ibm.com>
2018-05-22 18:41 ` Rogerio Alves
2018-05-23  9:27   ` Alexander Monakov [this message]
2018-05-23 12:33     ` Rogerio Alves
2018-05-23 13:45       ` Tulio Magno Quites Machado Filho
2018-05-23 14:25       ` Alexander Monakov
2018-05-25 19:39         ` Rogerio Alves
2018-06-04 14:34           ` Rogerio Alves
2018-06-04 14:38             ` Florian Weimer
2018-06-21 19:14               ` Rogerio Alves
2018-07-16 19:11                 ` Tulio Magno Quites Machado Filho
2018-05-15 17:29 Rogerio Alves
2018-05-15 18:53 ` Florian Weimer
2018-05-15 19:15   ` Rogerio Alves
2018-05-15 20:49   ` Tulio Magno Quites Machado Filho
2018-05-16 19:36     ` Rogerio Alves
2018-05-16 20:56       ` Adhemerval Zanella

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LNX.2.20.13.1805231219280.27433@monopod.intra.ispras.ru \
    --to=amonakov@ispras.ru \
    --cc=libc-alpha@sourceware.org \
    --cc=rcardoso@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).