public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Alexander Monakov <amonakov@ispras.ru>
To: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>
Cc: "H.J. Lu" <hjl.tools@gmail.com>,
	GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH v2] x86-64: Optimize strcmp/wcscmp with AVX2
Date: Sat, 02 Jun 2018 07:46:00 -0000	[thread overview]
Message-ID: <alpine.LNX.2.20.13.1806021022140.1892@monopod.intra.ispras.ru> (raw)
In-Reply-To: <03bdf89c47880fd0734fc5b82213fc3c98eab372.camel@linux.intel.com>

On Fri, 1 Jun 2018, Leonardo Sandoval wrote:
> this is partially true for AVX2 FMA and AVX512. What I am proposing
> contains none of the latter instructions, just AVX2 without FMA
> instructions.

This would address my concern (if true for all CPUs), but ...

> In the other hand, some microbenchmarks were done to see the benefit of
> this effort, which is resumed on the commit description but the
> complete picture is here 

this does not. The whole point was that frequency behavior means the
slowdown on programs making *occasional* calls to strcmp will not be
captured by microbenchmarks. What good is saving dozens of cycles on
strcmp calls if the remaining program is slowed down by 5%?

I was missing that AVX frequency limits kick in only if "heavy" operations
are used -- on recent generations. I'm not sure that's true for older, e.g.
Haswell, generations. Intel's white paper explaining Haswell AVX clocks
makes no distinction of "light" vs. "heavy" operations:

https://www.intel.com/content/dam/www/public/us/en/documents/white-papers/performance-xeon-e5-v3-advanced-vector-extensions-paper.pdf

Can you please clarify further?

Alexander

  reply	other threads:[~2018-06-02  7:46 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-29 18:53 leonardo.sandoval.gonzalez
2018-06-01 14:46 ` H.J. Lu
2018-06-01 15:30   ` Alexander Monakov
2018-06-01 20:23     ` Leonardo Sandoval
2018-06-02  7:46       ` Alexander Monakov [this message]
2018-06-02 11:37         ` Florian Weimer
2018-06-04 14:14         ` Leonardo Sandoval
2018-06-05 10:14           ` Alexander Monakov
2018-06-05 14:02             ` Leonardo Sandoval

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LNX.2.20.13.1806021022140.1892@monopod.intra.ispras.ru \
    --to=amonakov@ispras.ru \
    --cc=hjl.tools@gmail.com \
    --cc=leonardo.sandoval.gonzalez@linux.intel.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).