From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on2049.outbound.protection.outlook.com [40.107.8.49]) by sourceware.org (Postfix) with ESMTPS id 58C553858D1E for ; Tue, 20 Jun 2023 14:25:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 58C553858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=j0Gxmd4TSJnLnqBtBH5Iq7YHz2qAsNJ0UCp4yynVaSk=; b=dOCobh59AJWr0FynkL6wHBPfnaUa5HG7ymvQaGNAztcuC5I3juKvWyYFOmXvAqYbzQOGCITgsZt5HqlWeRil0I3ORrnOpeXjXLUrYcoEz9BfPBLgOtuFtHa+LMm4IRGqKaEC356ctxMnqhhKnTZVoWdYLf2Xr2RCEqCkz1fTlcU= Received: from AM0PR01CA0154.eurprd01.prod.exchangelabs.com (2603:10a6:208:aa::23) by AS2PR08MB9872.eurprd08.prod.outlook.com (2603:10a6:20b:593::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.37; Tue, 20 Jun 2023 14:25:14 +0000 Received: from AM7EUR03FT057.eop-EUR03.prod.protection.outlook.com (2603:10a6:208:aa:cafe::a1) by AM0PR01CA0154.outlook.office365.com (2603:10a6:208:aa::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.37 via Frontend Transport; Tue, 20 Jun 2023 14:25:14 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT057.mail.protection.outlook.com (100.127.140.117) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.23 via Frontend Transport; Tue, 20 Jun 2023 14:25:14 +0000 Received: ("Tessian outbound 5154e9d36775:v136"); Tue, 20 Jun 2023 14:25:14 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: acccfd74e1f3b31c X-CR-MTA-TID: 64aa7808 Received: from 8cdee04a7502.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 119E87EC-DB4C-4C9E-AECA-F3C977E7B524.1; Tue, 20 Jun 2023 14:25:07 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 8cdee04a7502.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 20 Jun 2023 14:25:07 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=au4S6TWyjgtIhbv5A5mIouOHRZOaN0Xo6UGOkisDHGtq45koGvAgKhtaIQLOlZUEwD+cU388grWx45Xre2n+is56h3/QzlVaD3U6iVBAML09d/2NtbeeLIF6Fsld/ZILfrQBOWaT4qXudQLpQVavS8wfmyM7aNtFElSOMZH/vpo5REcHNRL0VxmB94xfrlINMpk4/fJCEjiznyQy4w+G1WOQqkHhB1tptEzSB2+pRfw1ShgcTjMJWgjkE9JXMqcXRd62AY3+V7y2vygRTqOw31dy3y7JBKQ4BVdMCmgaUjbNwCH28UgRhnRg0dCAq2x1a16CZi9BfRO4igp/8v2aKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=j0Gxmd4TSJnLnqBtBH5Iq7YHz2qAsNJ0UCp4yynVaSk=; b=EQzI0BLOijKY8MIewK6oQGs763fQ8q+yPUk2iKd8iPrZY6S0elHJ06pKr4M0xpg2oW91VOJP9dFiZj6WT7KrMxE8BAfrrUiSgyUg87E3g30UFr6IHS9D4yn+EEGGw1poH3w+YWCyWKZHqDWtD61icB+yWEUBDFtkzD/gIDLM9FvrEmZPg/muYo6RMvk5M+hER+NGs3fV76GHwM7ZquzfHIU5Q/+3tqjDXO+glBFbaBApcVKslZek8iQ7Ztcf5oILcfYavFoWUxTwHY15GTVz7qZ6GYVJIyH1hzUMWgGg5c5M7RvmJrSi68IG0cSlhAbpKYTmCce35eAf2eu0sqbdgA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=j0Gxmd4TSJnLnqBtBH5Iq7YHz2qAsNJ0UCp4yynVaSk=; b=dOCobh59AJWr0FynkL6wHBPfnaUa5HG7ymvQaGNAztcuC5I3juKvWyYFOmXvAqYbzQOGCITgsZt5HqlWeRil0I3ORrnOpeXjXLUrYcoEz9BfPBLgOtuFtHa+LMm4IRGqKaEC356ctxMnqhhKnTZVoWdYLf2Xr2RCEqCkz1fTlcU= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AM6PR08MB4951.eurprd08.prod.outlook.com (2603:10a6:20b:eb::29) by PAVPR08MB9091.eurprd08.prod.outlook.com (2603:10a6:102:32d::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.36; Tue, 20 Jun 2023 14:25:05 +0000 Received: from AM6PR08MB4951.eurprd08.prod.outlook.com ([fe80::7018:c39a:6209:90c5]) by AM6PR08MB4951.eurprd08.prod.outlook.com ([fe80::7018:c39a:6209:90c5%4]) with mapi id 15.20.6500.036; Tue, 20 Jun 2023 14:25:05 +0000 Message-ID: Date: Tue, 20 Jun 2023 15:25:03 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v2 1/4] aarch64: Add vector implementations of cos routines Content-Language: en-US To: Richard Henderson , libc-alpha@sourceware.org References: <20230619145634.18801-1-Joe.Ramsay@arm.com> <96cc5d82-ccad-a3ce-5ec0-3a22d807c24a@linaro.org> From: Joe Ramsay In-Reply-To: <96cc5d82-ccad-a3ce-5ec0-3a22d807c24a@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0092.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:191::7) To AM6PR08MB4951.eurprd08.prod.outlook.com (2603:10a6:20b:eb::29) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AM6PR08MB4951:EE_|PAVPR08MB9091:EE_|AM7EUR03FT057:EE_|AS2PR08MB9872:EE_ X-MS-Office365-Filtering-Correlation-Id: 97fe3cf1-9468-4b66-3a95-08db719a2a0c x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: j/Qv6rpigSocxKAlYWSgP35EgNb1OmR6cEcCm6lSnJ/5svE4WUW7jD2ZeUSgiLtBzdLVA5nJWHKedNJD8RWEQ96GmOBBE6cA8MS2k7rGof0INmSEr86KXkkC0aDBCjPsmkhlkvAdl4kSQ8T+2RkwDWQ5bIRjw3UbGW4rqI1S8dtLdcQi08c16Ldw8FcMcG3j09NPGwm0MbIkUXXXffLknaBIs41n7lqH3zdM8dFle4t+npcyCzaG6ONvHqVFItCwO5joE1uc1/X3XJZzi0Msx6qaUpYyl7a2UK4ToWmvtsJK20HZtS+HBZJm71Ilc+B1KogtmpvgxWRRWimAaEmm8ieVSCg8Q5DKGILeOmcjLKkYRnVDYFimLOLCjfGuwE3BzTDa3SBM/ue5qjAGKRQHOlIkCoD/PEo+goAQn+468/shQM7JCHg2DKUT2VdHvgWls/sm0xByuA/bnqM4uExWYt+Pf0HZIjU+FH40sj4A6QpmTQ0pmkn57+7cn8N5E9bF15CAg1AJ2d/leKgeZUgqa6t63O1C2XQxSMPP5GUzw5UxBgekoyLvoAK8wgwHIIe3Vot9mr1Eck2J5BHQY1lG+xUo1uZdGjTgOhfrA1vGiVs9XaXuBlQISNIdJNYDSrQuigAky1cxC2oB3VmT928ypQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB4951.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(136003)(396003)(346002)(366004)(376002)(39860400002)(451199021)(31696002)(44832011)(31686004)(38100700002)(86362001)(41300700001)(8936002)(8676002)(5660300002)(66476007)(66556008)(66946007)(316002)(2616005)(53546011)(6506007)(6512007)(26005)(186003)(6486002)(478600001)(2906002)(4744005)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9091 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT057.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 20de02bb-070e-4bc9-df1b-08db719a242b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VxsWGdbq9YV9H1MWdr2Ol32u3p0ZXT7eLoWq8+Ncj514HNDyVQen37AFE8OJ6r7BxD74B6YfKPfsXNM2x1EBB03hkGEi+a9djBnX9bYvWYXvmKFQe3LaN15o6WfWUObXZBSgScc6BUmQ4nIMp/dzf8gKD0QFR9MhoEkm8YJiwR0tVcy/2+ud7g/6vGhiR+qrK+Rtj2oHnVsav0FSjCIFXQ3jrMMt2j+e+CMsrfr6gDPl0H3nR+XM1a3+c7rAFHYxfZaTjQvPtekry2P4JFZ7W0ibe1k3CaRYJejDKC2ACRn93lN2Hm0kWayrTEpIHSP0aQvPriL8iwg0qjhigWMLshfWxE49X756pFqLUamkEFCCdUinPbgXyr59gv+3k3YKnTDaxqzU2MManthxOOjyph8dBqlGk5WjWQLVp78k9ANcC0pzbKG8Qp3CYl892eJbFDJetrCL+tZjkVXhz5CTVedz8R2o+dENFwuPJeWOlYre+KK+PNfElR1dFIKYzRpTNQ0kq3lHnQWoJJvDFWqI60zpe9BSYiVPrXwusSb2/Krkk3protbjCyfnBNYXwj/GHt15e49aGWUWJsuUyjcxvjyO2Kls5Owi7Y4M89zGr5utnjpljjtp5qzyJ4vpB081NXVhklVW2RzFWBmVaiOKYYoHRM0BlYZLT2zvQGfXG/Sm2fXbb/C/r9Qy6y5mO5zzRH8fkT1aPorsvQuDSbeSmUF4y5oO2kQa8CmyinS4JYP6guYvdVgE9lCakejX0yYyPnLZ/J1syjt3oNSLNT62vQTKMdz1j1yfa5/5YEvUGgoLBuW14L/MrkGQzLyVYY1M X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(376002)(346002)(39860400002)(396003)(136003)(451199021)(40470700004)(36840700001)(46966006)(40460700003)(47076005)(4744005)(6486002)(82310400005)(6512007)(82740400003)(356005)(81166007)(2616005)(53546011)(26005)(186003)(6506007)(36860700001)(41300700001)(2906002)(31696002)(86362001)(336012)(316002)(478600001)(36756003)(40480700001)(70206006)(70586007)(5660300002)(8936002)(8676002)(31686004)(44832011)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jun 2023 14:25:14.6778 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 97fe3cf1-9468-4b66-3a95-08db719a2a0c X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT057.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB9872 X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,KAM_DMARC_NONE,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Richard, On 19/06/2023 16:18, Richard Henderson wrote: > Surely 'const' is always preferred. > > If you want to force the single adrp, then > >     __typeof (data) *d = &data; >     asm ("" : "+r"(d)); > > may be a better solution.  Especially vs writable constants. Thanks for the suggestion. We observe slightly worse codegen this way - something about this confuses the register allocator in GCC, to the extent that in some routines (for example SVE sin) we see extra loads and stores to preserve callee-saved registers. We would rather keep the existing, slightly more performant, approach. Thanks, Joe