From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by sourceware.org (Postfix) with ESMTPS id 6A2603858D28 for ; Mon, 20 May 2024 19:07:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6A2603858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6A2603858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::632 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716232077; cv=none; b=V0pm6zIqx5ijNk0OWLFooUyL9Le67fZNAogESH1hAPxMpRKniLaOjaOrKdDFwvKWA8GM0Jk7PPhkUIImN24ubXLP6eMRil8/vkFI8tWl9f+ycYFwqfGEcChF/Sb0uy0K3WssgWDuF/OoTgv+jLvH8mEOE09+6mFj5Bsa+52Ay6c= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716232077; c=relaxed/simple; bh=Va2zbpm8XhnWXjZ38ZDDPohg+SOYY3qsVhF+/1FLmac=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=qF2wit1FRluvriXC1NFMImr95RFaMj3frDIr6IO8C9BIY4MzmbSFr9vLme2v0VKFzzzgqX247umDxXGceLlnVQVqGhW3oEdanlIheTA5ShCKqeikx+H7d5328NF2UUfLoLlpHHNy/tVoplsndgyNksL2kO5QAu9Kr80D+FtV2ds= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x632.google.com with SMTP id d9443c01a7336-1ecd3867556so87815475ad.0 for ; Mon, 20 May 2024 12:07:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1716232074; x=1716836874; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=Ty+NbSZ6/UuPMRPOuCyQMSqArwU/TClEpXf/zbX1Qc0=; b=Jm5r1Dah/jeWWmxrteP0gB8v5zuYIiBhSKvKou42Dx2jBuXRkgBFwFprYNdD3yshOZ OnG4abICAU4v/SzDqVpF8utY/1K8tkMF9I9v3Fkn/qonomiSj/GQG0WXgGmcQnqbD6Rk /pFosgMU16TbxOkK+3fwvRPFBV1txQB1k9GFB3vhl5eDGdasNwI0bczX0txditLyHpH5 DZNrdIFqlDNoY8AunX5Ys27HKvsIYEPB5LMp1mE9wwg8PwNFUeb4haoCmoAUe9pOl36+ eYkm2IHZC+vtV2blaMF9CKjKnleAhmOc157WTB/fhGTTfwbGN+cPjqYWvEjbqneyufsb dK0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716232074; x=1716836874; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Ty+NbSZ6/UuPMRPOuCyQMSqArwU/TClEpXf/zbX1Qc0=; b=BHOeoB+gmDnTlvv59Ph7VGhCzFtAwYqW9n5C7rhmUjxHyPY+iClOs2SQYNPxR1IsLy RXGOI5VNVeNmIJkHXPOf5hCIHopuf0mZ3D+sgWIUOBZhVYJFUBfuf7QPibytlU8Sqtj2 3Hdewgy49a4jwRL7hO/HnQQD+KZVgjeEkSM53PUY1I9SsuCFhsTtAKgGmNUZ9g8gkgZc YdEiZ7UQox6G+dSLle2NQZtAdXakxelERqHw9g/dHIZzGWI0XHyNGrRby94QnvAjt/H/ H3bWrEIlnKd/E+uQX1TbZR6FDt5x7iAxWZxLsGbnd8UlgD5FgJHGzwuGfQTlSCYqERPX Mk9g== X-Gm-Message-State: AOJu0Yxb9Hr4URpNsB9TM7s9SN6scyQ1Hj4pIaVWU8kLwR62dL0NWpgW FSXOvRnML4xSjG7J9OOTuK5+tGgz+Q97ZdGOi1SKylLTHjtJiPdMv2x3JoQeb6EQVER0cj9uqcf H X-Google-Smtp-Source: AGHT+IH92X/kr1Kq4EzGNJREpBqkphojryNu2SbiNISDihjhajwF6+apk1ewEM3CEuygpIGkS9ETqA== X-Received: by 2002:a17:903:228f:b0:1f2:fd5d:ced0 with SMTP id d9443c01a7336-1f2fd5dddfbmr50844495ad.12.1716232074455; Mon, 20 May 2024 12:07:54 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c2:f76a:4d8e:551e:8ee4:7221? ([2804:1b3:a7c2:f76a:4d8e:551e:8ee4:7221]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f3029cfcc3sm20259135ad.130.2024.05.20.12.07.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 May 2024 12:07:53 -0700 (PDT) Message-ID: Date: Mon, 20 May 2024 16:07:51 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 7/7] math: Provide modf128 for static libm on alpha, s390, and sparcv9 To: "H.J. Lu" Cc: libc-alpha@sourceware.org, Joseph Myers , Florian Weimer References: <20240402140644.2172819-1-adhemerval.zanella@linaro.org> <20240402140644.2172819-8-adhemerval.zanella@linaro.org> Content-Language: en-US From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 20/05/24 13:59, H.J. Lu wrote: > On Tue, Apr 2, 2024 at 7:07 AM Adhemerval Zanella > wrote: >> >> Checked with a build for the affected ABIs >> --- >> sysdeps/ieee754/ldbl-64-128/s_modfl.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/sysdeps/ieee754/ldbl-64-128/s_modfl.c b/sysdeps/ieee754/ldbl-64-128/s_modfl.c >> index 7d7aeae111..ba3d31334a 100644 >> --- a/sysdeps/ieee754/ldbl-64-128/s_modfl.c >> +++ b/sysdeps/ieee754/ldbl-64-128/s_modfl.c >> @@ -1,10 +1,10 @@ >> #include >> #include >> -#if IS_IN (libc) >> +#if IS_IN (libc) && defined SHARED >> # undef libm_alias_ldouble >> # define libm_alias_ldouble(from, to) >> #endif >> #include >> -#if IS_IN (libc) >> +#if IS_IN (libc) && defined SHARED >> long_double_symbol (libc, __modfl, modfl); > > Doesn't this remove modfl from static library? As for copysignf128 and frexp128, this symbol is also provided by libc.a. Before this patch: alpha-linux-gnu$ readelf -sW libc.a | grep -w modf.* 19: 0000000000000000 572 FUNC WEAK DEFAULT [STD GPLOAD] 1 modfl 17: 0000000000000000 304 FUNC WEAK DEFAULT [STD GPLOAD] 1 modff32x 18: 0000000000000000 304 FUNC WEAK DEFAULT [STD GPLOAD] 1 modff64 19: 0000000000000000 304 FUNC WEAK DEFAULT [STD GPLOAD] 1 modf 17: 0000000000000000 244 FUNC WEAK DEFAULT [STD GPLOAD] 1 modff32 18: 0000000000000000 244 FUNC WEAK DEFAULT [STD GPLOAD] 1 modff After this patch: alpha-linux-gnu$ readelf -sW libc.a | grep -w modf.* 19: 0000000000000000 572 FUNC WEAK DEFAULT [STD GPLOAD] 1 modff64x 20: 0000000000000000 572 FUNC WEAK DEFAULT [STD GPLOAD] 1 modff128 21: 0000000000000000 572 FUNC WEAK DEFAULT [STD GPLOAD] 1 modfl 17: 0000000000000000 304 FUNC WEAK DEFAULT [STD GPLOAD] 1 modff32x 18: 0000000000000000 304 FUNC WEAK DEFAULT [STD GPLOAD] 1 modff64 19: 0000000000000000 304 FUNC WEAK DEFAULT [STD GPLOAD] 1 modf 17: 0000000000000000 244 FUNC WEAK DEFAULT [STD GPLOAD] 1 modff32 18: 0000000000000000 244 FUNC WEAK DEFAULT [STD GPLOAD] 1 modff > >> #endif >> -- >> 2.34.1 >> > >