From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 4260A3858018 for ; Tue, 23 Feb 2021 04:06:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 4260A3858018 Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-429-R5lgkEM1MfqKhW6KCJdGpA-1; Mon, 22 Feb 2021 23:06:18 -0500 X-MC-Unique: R5lgkEM1MfqKhW6KCJdGpA-1 Received: by mail-qt1-f197.google.com with SMTP id i19so9156735qtx.6 for ; Mon, 22 Feb 2021 20:06:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=AVfeunOhbrE4s6vnCJHWVTr7N9265u69q5QrWZq1lZQ=; b=IP0o5iKM2YzD3TIShY9cK/3O3WjgJT7C0TszgS3JHzIU1OoZ1KiIZC0d1lJAzWWqdQ VJFzQJUjFtilD95YNEg4OXHUejd8LJTbd1VZcPBq9dN0aACVNuZS5byXyM16EkBDfNMe MAj3zNEq8ji9gTp5GjphCYp4QuaLUpT4pBMfjt9uwkY3hvrBt/h4tcch4Hf+lC0jdSc5 KeVZ+jfEzwPD9AkXVLIhYsont9fDsykREIthcM3DXZSSYQNrAD4F5z4XU6/94/iKB+Lq Kr+djeau3RyuHQzy/GWyl/+apwIchaF9SgiITWdOoIJNLQ5f0gOX8WorECI75RSO9KtI f/oQ== X-Gm-Message-State: AOAM53000EbpwHztX35XacU0aHFJR+pAwpZ0P6qOkDyZlygGwy9l08OY STC6DzF7D4qRAaYKc8GHV6Cs0t8uFFn5a6M/MbKXni2ShJDaRXSju2nNmUv3DjjpQoizz9iwwkP +zOsTUOFT5lOFQsggsPannqnzsyHWuPYMuq5P9sgURlVLRvyXM2OuTrlL50cfdT0II11v+A== X-Received: by 2002:a37:418d:: with SMTP id o135mr21214093qka.293.1614053177919; Mon, 22 Feb 2021 20:06:17 -0800 (PST) X-Google-Smtp-Source: ABdhPJw1gU5DnMHT0bTC5ACnKHIYaDS5J0Bl7O6VRlOV3HOCI28xYttEGxkWR8+MxhCqmEUs5vwkmg== X-Received: by 2002:a37:418d:: with SMTP id o135mr21214082qka.293.1614053177702; Mon, 22 Feb 2021 20:06:17 -0800 (PST) Received: from [192.168.1.16] (198-84-214-74.cpe.teksavvy.com. [198.84.214.74]) by smtp.gmail.com with ESMTPSA id m9sm5576086qth.40.2021.02.22.20.06.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Feb 2021 20:06:17 -0800 (PST) Subject: Re: [patch] nss: fix nss_database_lookup2's alternate handling [27416] To: DJ Delorie Cc: libc-alpha@sourceware.org References: From: Carlos O'Donell Organization: Red Hat Message-ID: Date: Mon, 22 Feb 2021 23:06:16 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Feb 2021 04:06:23 -0000 On 2/22/21 8:16 PM, DJ Delorie wrote: > "Carlos O'Donell" writes: >> On 2/19/21 5:22 PM, DJ Delorie via Libc-alpha wrote: >>> >>> https://sourceware.org/bugzilla/show_bug.cgi?id=27416 >> >> Could you please provide the full commit message you plan to >> use for this commit? > > That was it. Is more required? The commit message should allow a reviewer to understand the problem in the briefest form without external reference. A few sentences about how we got here and why, and what corrective steps are being taken would be useful for a commit message. For inspiration please see: https://sourceware.org/glibc/wiki/Contribution%20checklist#Commit_message_body A full URL reference to sourceware is also not required. The subject bug reference should be in one of two forms for automated processing: (bug xxxx), or [BZ #xxxx]. Please adjust >> If you commit your change locally then do: >> git format-patch HEAD~1 >> git send-email mydiff.patch > > I commit my change locally, use gitk to extract it, then mail it on a > different machine. That's all OK, you can run git send-email on that remote system if you like (avoids MUA problems). https://sourceware.org/glibc/wiki/Contribution%20checklist#Generate_patch `git format-patch` is the recommended way to get the format that a reviewer is expecting. >> Please repost v2. > > What changes are required? Please repost v2 with the suggested commit message changes for review. Reviewing the commit message is part of the review. When the review is complete the only difference between what is reviewed and what is committed should be the added Reviewed-by line. >>> + else if (strcmp (p->pw_name, "name100") != 0) >>> + FAIL_EXIT1("getpwuid-compat-test1 name100"); >> >> OK. Password uses compat which redirects to test1 instead of files. >> So seeing name100 means files was used and that's wrong. > > "name100" comes from test1; we're testing that it *is* returned, which > means test1 *is* being used to back compat. OK. -- Cheers, Carlos.