From: Carlos O'Donell <carlos@redhat.com>
To: Siddhesh Poyarekar <siddhesh@gotplt.org>,
Siddhesh Poyarekar <siddhesh@sourceware.org>,
libc-alpha@sourceware.org
Cc: Stefan Liebler <stli@linux.ibm.com>
Subject: Re: [PATCH] Exclude tst-realloc from tests-mcheck
Date: Tue, 6 Jul 2021 13:58:52 -0400 [thread overview]
Message-ID: <b0903d00-b321-3f3b-3ac0-1f8b69b9da5a@redhat.com> (raw)
In-Reply-To: <0b28f333-c83a-d3e8-c825-d424b40162e7@gotplt.org>
On 7/6/21 12:12 PM, Siddhesh Poyarekar wrote:
> On 7/6/21 9:31 PM, Siddhesh Poyarekar via Libc-alpha wrote:
>> The realloc (NULL, 0) test in tst-realloc fails with gcc 7.x but
>> passes with newer gcc. This is because a newer gcc transforms the
>> realloc call to malloc (0), thus masking the bug in mcheck.
>>
>> Disable the test with mcheck for now. The malloc removal patchset
>> will fix this and then remove this test from the exclusion list.
>>
>> I'll push this soon if there are no objections. I'll also post an
>> updated malloc hooks patchset with these issues fixed.
>>
>> Reported-by: Stefan Liebler <stli@linux.ibm.com>
>
> I just remembered that the tree is in slushy freeze. Carlos, would you approve this? I will rebase the malloc hooks patchset on top of this.
This is a non-ABI bug fix which is OK in the slushy freeze which only
coves ABI changes.
--
Cheers,
Carlos.
next prev parent reply other threads:[~2021-07-06 17:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-06 16:01 Siddhesh Poyarekar
2021-07-06 16:12 ` Siddhesh Poyarekar
2021-07-06 17:58 ` Carlos O'Donell [this message]
2021-07-06 17:59 ` Carlos O'Donell
2021-07-07 7:49 ` Stefan Liebler
2021-07-07 7:59 ` Siddhesh Poyarekar
2021-07-07 8:07 ` Stefan Liebler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0903d00-b321-3f3b-3ac0-1f8b69b9da5a@redhat.com \
--to=carlos@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=siddhesh@gotplt.org \
--cc=siddhesh@sourceware.org \
--cc=stli@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).