From: Florian Weimer <fweimer@redhat.com>
To: GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH] extras: New test/build infrastructure
Date: Fri, 25 Nov 2016 16:16:00 -0000 [thread overview]
Message-ID: <b092720c-61a0-2d3e-f505-01f2c8d9b39f@redhat.com> (raw)
In-Reply-To: <9426ee75-3e45-6cde-b659-567398007a32@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 980 bytes --]
On 11/25/2016 04:59 PM, Florian Weimer wrote:
> I have split up test-skeleton.c into its components. The new test
> skeleton should be compatible with compilation in C90 mode. I expect to
> use some of these helper functions for future build support on the host
> (that is, these routines will have to be compiled twice, once against
> the built libc, and once against the host libc).
>
> I converted a few tests to make sure that this works as expected.
>
> I do not propose bulk migration at this point. Some obscure use cases
> are not supported by the exported hooks.
>
> If you think this goes in the right direction, I will port over my
> container-based nss_files testing, and the resolver test suite to this
> infrastructure. It also eliminates the need for the hack in my fix for
> bug 16421 I posted earlier.
>
> Tested on aarch64, ppc64le, s390x, x86_64.
Testing on i386 revealed that the following change to the temporary file
infrastructure is needed.
Florian
[-- Attachment #2: extras-32.patch --]
[-- Type: text/x-patch, Size: 480 bytes --]
diff --git a/extras/temp_file.c b/extras/temp_file.c
index 32b6560..a409d7a 100644
--- a/extras/temp_file.c
+++ b/extras/temp_file.c
@@ -16,6 +16,10 @@
License along with the GNU C Library; if not, see
<http://www.gnu.org/licenses/>. */
+/* This is required to get an mkstemp which can create large files on
+ some 32-bit platforms. */
+#define _FILE_OFFSET_BITS 64
+
#include <extras/temp_file.h>
#include <extras/temp_file-internal.h>
#include <extras/extras.h>
next prev parent reply other threads:[~2016-11-25 16:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-25 15:59 Florian Weimer
2016-11-25 16:14 ` Zack Weinberg
2016-11-25 17:11 ` Andreas Schwab
2016-11-25 17:46 ` Florian Weimer
2016-11-25 17:45 ` Florian Weimer
2016-11-25 18:44 ` Zack Weinberg
2016-11-25 18:49 ` Florian Weimer
2016-11-25 16:16 ` Florian Weimer [this message]
2016-11-25 17:29 ` Joseph Myers
2016-11-25 17:48 ` Florian Weimer
2016-11-25 18:24 ` Joseph Myers
2016-11-25 19:26 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b092720c-61a0-2d3e-f505-01f2c8d9b39f@redhat.com \
--to=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).