From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27715 invoked by alias); 25 Nov 2016 16:16:41 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 27691 invoked by uid 89); 25 Nov 2016 16:16:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=revealed, Hx-languages-length:1492 X-HELO: mx1.redhat.com Subject: Re: [PATCH] extras: New test/build infrastructure To: GNU C Library References: <9426ee75-3e45-6cde-b659-567398007a32@redhat.com> From: Florian Weimer Message-ID: Date: Fri, 25 Nov 2016 16:16:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <9426ee75-3e45-6cde-b659-567398007a32@redhat.com> Content-Type: multipart/mixed; boundary="------------13BD27AB7E1FBF93756D1B60" X-SW-Source: 2016-11/txt/msg00928.txt.bz2 This is a multi-part message in MIME format. --------------13BD27AB7E1FBF93756D1B60 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-length: 980 On 11/25/2016 04:59 PM, Florian Weimer wrote: > I have split up test-skeleton.c into its components. The new test > skeleton should be compatible with compilation in C90 mode. I expect to > use some of these helper functions for future build support on the host > (that is, these routines will have to be compiled twice, once against > the built libc, and once against the host libc). > > I converted a few tests to make sure that this works as expected. > > I do not propose bulk migration at this point. Some obscure use cases > are not supported by the exported hooks. > > If you think this goes in the right direction, I will port over my > container-based nss_files testing, and the resolver test suite to this > infrastructure. It also eliminates the need for the hack in my fix for > bug 16421 I posted earlier. > > Tested on aarch64, ppc64le, s390x, x86_64. Testing on i386 revealed that the following change to the temporary file infrastructure is needed. Florian --------------13BD27AB7E1FBF93756D1B60 Content-Type: text/x-patch; name="extras-32.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="extras-32.patch" Content-length: 480 diff --git a/extras/temp_file.c b/extras/temp_file.c index 32b6560..a409d7a 100644 --- a/extras/temp_file.c +++ b/extras/temp_file.c @@ -16,6 +16,10 @@ License along with the GNU C Library; if not, see . */ +/* This is required to get an mkstemp which can create large files on + some 32-bit platforms. */ +#define _FILE_OFFSET_BITS 64 + #include #include #include --------------13BD27AB7E1FBF93756D1B60--