From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by sourceware.org (Postfix) with ESMTPS id 130A03954C13 for ; Tue, 27 Oct 2020 16:35:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 130A03954C13 Received: by mail-wr1-x443.google.com with SMTP id x7so2652830wrl.3 for ; Tue, 27 Oct 2020 09:35:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:cc:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=IUiVVduRbB+5EqIBIHaAEXxUPcqU/MJxAXG6jWNsfPk=; b=pvKoXmKyfkAjIchWByw0OT0ZMby1NfCRy57rRDqFNDD8zBi0hOIivuJ1qNUPMLiGeD jmc0OShDUmWTRQS0q5yDUkU1GmCrwMfo3TnHkrtAXeOyVv7nb1RlxGVHY3hWG6n0ERKl oFBPnJYtf2P0NiGa3qoYqDKY10SM7L9xG+tCyMHdFB4htsdrGKiWEj1GVaYyI93AvV7V 3dqigWpFJ8d+eryfdgO94glwQnt9YONcC2Mn5wOxZqMaQl+2PP7/6JWMyoAH32WHBQOK uci60JlJIIToE82pA8E2m8cZLUkNmBxM4Sfvhho+VLlFHDBD3qe4o9ToUMXp9CafL4zo R3GQ== X-Gm-Message-State: AOAM530amvGw4hhZ6twvDbSfWZOdDOB993GsTj94AqIu3IEg1MSV/ZGA Sf3LOjw1cCtgQzI/yBBCal99RoHi0bw= X-Google-Smtp-Source: ABdhPJwaBox2Zh8vqQxV2lmy6iby+y9venQ/9yOdnhk4MmQLXayK5oCnWuDPso1r7Y6YkI95u3xZOw== X-Received: by 2002:adf:fdcf:: with SMTP id i15mr4068453wrs.16.1603816509892; Tue, 27 Oct 2020 09:35:09 -0700 (PDT) Received: from ?IPv6:2001:a61:245a:d801:2e74:88ad:ef9:5218? ([2001:a61:245a:d801:2e74:88ad:ef9:5218]) by smtp.gmail.com with ESMTPSA id o3sm2684215wru.15.2020.10.27.09.35.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Oct 2020 09:35:08 -0700 (PDT) Cc: mtk.manpages@gmail.com, linux-man@vger.kernel.org, libc-alpha@sourceware.org Subject: Re: [PATCH 0/6] Add loff_t & off64_t, and update off_t To: Alejandro Colomar References: <20201027162114.47521-1-colomar.6.4.3@gmail.com> From: "Michael Kerrisk (man-pages)" Message-ID: Date: Tue, 27 Oct 2020 17:35:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20201027162114.47521-1-colomar.6.4.3@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, KAM_SHORT, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Oct 2020 16:35:12 -0000 Hi Alex, On 10/27/20 5:21 PM, Alejandro Colomar wrote: > Hi M, > > I added some details to off_t, > and added loff_t and off64_t to the page. > > Maybe you would like to improve some wording on these patches. > There are a few lines that don't convince me fully... > > I might start working on fixing the messy *lseek* pages. See my other mail. On reflection, I think that those pages are in a "good enough" state. And, you raced off a bit too quick for me. I definitely think loff_t should not be added. And I'm pretty doubtful about adding off64_t as well. I've applied patch 2 in this series. Thanks, Michael > Alejandro Colomar (6): > system_data_types.7: off_t: SEE ALSO: Uncomment loff_t, off64_t > system_data_types.7: off_t: Add note about _FILE_OFFSET_BITS > system_data_types.7: Add 'loff_t' > loff_t.3: New link to system_data_types(7) > system_data_types.7: Add 'off64_t' > off64_t.3: New link to system_data_types(7) > > man3/loff_t.3 | 1 + > man3/off64_t.3 | 1 + > man7/system_data_types.7 | 76 ++++++++++++++++++++++++++++++++++++---- > 3 files changed, 71 insertions(+), 7 deletions(-) > create mode 100644 man3/loff_t.3 > create mode 100644 man3/off64_t.3 > -- Michael Kerrisk Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ Linux/UNIX System Programming Training: http://man7.org/training/