From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=W7MK=DG=mentor.com=joseph_myers@sourceware.org>
Received: from esa1.mentor.iphmx.com (esa1.mentor.iphmx.com [68.232.129.153])
	by sourceware.org (Postfix) with ESMTPS id 34A0638555A4
	for <libc-alpha@sourceware.org>; Thu, 20 Jul 2023 17:43:39 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 34A0638555A4
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com
X-IronPort-AV: E=Sophos;i="6.01,219,1684828800"; 
   d="scan'208";a="13950334"
Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167])
  by esa1.mentor.iphmx.com with ESMTP; 20 Jul 2023 09:43:37 -0800
IronPort-SDR: GOSD3MDe9cNSpU6GEI/Ku4yRVN/Zkx3EG8Rh4KROXrhRgqZHRG/jT+KItOGkmYbNM7K3kjCvme
 zmlU7NsnQRcU2ck3l4GqSVz1+NkQI/sFlaAIbeQ0tSQgw/u5FSYrbQ8Jje6mpVrjD22Fs3aJzW
 0K6IBFSeK5re8yvGp0rPjGPtFo4mODgzfMagRBran2RM07RQMFn20D5fvbkKAnJ8TDNbcDSzv6
 pQRU0CNVBc8Y7HEh+jhVn+Wn7WbYotxyvnjFFo4nx/47BT5WVQ66VVCcdadB2WY0S3sSgsKzUj
 rIA=
Date: Thu, 20 Jul 2023 17:43:32 +0000
From: Joseph Myers <joseph@codesourcery.com>
To: Jeff Law <jeffreyalaw@gmail.com>
CC: Jakub Jelinek <jakub@redhat.com>, Siddhesh Poyarekar
	<siddhesh@gotplt.org>, Konstantin Ryabitsev <konstantin@linuxfoundation.org>,
	Florian Weimer <fweimer@redhat.com>, Carlos O'Donell via Libc-alpha
	<libc-alpha@sourceware.org>, Carlos O'Donell <carlos@redhat.com>, "Ryan S.
 Arnold" <ryan.arnold@gmail.com>, Paul Eggert <eggert@cs.ucla.edu>, Maxim
 Kuvyrkov <maxim.kuvyrkov@linaro.org>, Andreas Schwab <schwab@suse.de>
Subject: Re: Core Toolchain Infrastructure - Services for glibc
In-Reply-To: <cb51b83f-fda4-7a15-4ba2-5ce2aa0b51eb@gmail.com>
Message-ID: <b0cfc0a9-73ae-a2ec-4ce7-6798d33d87d@codesourcery.com>
References: <45e98807-908f-0968-b6fe-5dbb0af265b1@redhat.com> <87ttu6oh9j.fsf@oldenburg.str.redhat.com> <20230714-card-radium-prow-27d2f1@meerkat> <2b743481-4dc3-07a1-fe65-a32a9d1df09a@gotplt.org> <ZLaFBGygP/n+uFY9@tucnak>
 <cb51b83f-fda4-7a15-4ba2-5ce2aa0b51eb@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
X-Originating-IP: [137.202.0.90]
X-ClientProxiedBy: svr-ies-mbx-14.mgc.mentorg.com (139.181.222.14) To
 svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10)
X-Spam-Status: No, score=-3105.4 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <libc-alpha.sourceware.org>

On Tue, 18 Jul 2023, Jeff Law via Libc-alpha wrote:

> BUt the key (I think) is they're not trybot/CI style hooks.  They're doing
> things like wiring up commits to the lists/bugzilla, verifying ChangeLog bits
> and the like.
> 
> I think the point is that any hooks need serious thought about what they do
> and the attack surface they represent.  So for example firing off pre-commit
> CI, not advisable.  Having a hook that queries another system for the state of
> pre-commit CI may be reasonable.
> 
> I would think that verifying ChangeLog format might fall into the reasonable
> space.  Not sure about lists/bz integration hooks.

Details of what the GCC hooks do / check are documented in the GCC service 
enumeration.

https://lore.kernel.org/cti-tac/7e59d8db-7b26-1249-ad5c-67b7f3411e1@codesourcery.com/T/#u

-- 
Joseph S. Myers
joseph@codesourcery.com