Re: [PATCH v2] hppa: Drop old parisc-specific MADV_* constants

[Helge Deller <deller@gmx.de>]

Hi Joseph,

On 2/22/23 16:35, Joseph Myers wrote:
> On Fri, 10 Feb 2023, Helge Deller via Libc-alpha wrote:
>
>> The Linux kernel upstream commit 71bdea6f798b ("parisc: Align parisc
>> MADV_XXX constants with all other architectures") dropped the
>> parisc-specific MADV_* values in favour of the same constants as
>> other architectures. In the same commit a wrapper was added which
>
> I'd like to enquire about another part of that commit.  It removes the
> #define of MAP_VARIABLE to 0, so resulting in tst-mman-consts failing if I
> update build-many-glibcs.py to use Linux 6.2.

Oh, didn't knew that.
Basically it wasn't necessary to drop MAP_VARIABLE, but since no other arch
defined it either and as it's not used anywhere in the kernel I assumed it's
ok to drop it.

> So we'll need to change
> tst-mman-consts.py to allow variation between userspace and kernel
> regarding whether that macro is defined (the expectation of the test being
> that newer kernels only add macros tested for, not remove them), but
> should we also remove that define in glibc?

Yes, I think that's the best solution. Keeps glibc and kernel in sync.

Thank you!
Helge