From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x22f.google.com (mail-oi1-x22f.google.com [IPv6:2607:f8b0:4864:20::22f]) by sourceware.org (Postfix) with ESMTPS id 12DC43857C4E for ; Mon, 7 Nov 2022 13:36:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 12DC43857C4E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oi1-x22f.google.com with SMTP id m204so12128887oib.6 for ; Mon, 07 Nov 2022 05:36:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=aZlqM0pNcbW4XKsu3+Y9DT96Y/oZm/f4V7JrFpyxCvY=; b=Ex3Bdyo+EgBCbJNdZ6F1MhbCGhJChW5CaRiF/qX+LAYASpMSIFjdVch9MKorQ1Qy5A t9yvmxIM+yKLSmXCtdaqpb6Xcb5SO1xjr7uPIBqoJojVNjC/JDdvXAhRTusZx5lGBq5S On8ytej3BrVXPRv88V7nlwKb0S0AwW1FY9bIxSz7BXJqqbsLcyOuUpGaVZvZrGO73UB+ Pj4mIsBnDnpSm8a/Pq9kHsT6/vKItXhyLqlmiUZG6y/88exZ73Xg3PWIHzH5dhIcNvwT f8I0H+1tdmHuUnnbwXiHskL8HIKPkMq4m/DzfVXbtf+09pQaCoOB+K+9TgOSGSsseuLW 4TNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=aZlqM0pNcbW4XKsu3+Y9DT96Y/oZm/f4V7JrFpyxCvY=; b=ob5HOS8Qdd+e8K8TgoLUuDZ4rGZFTgk2zKxcVo4S8Qp16Xvtkcp3YVS3PIjCWsVZKv CeF0j9ZTLMsi7cBUS4tSS+b5typs6r6R6reI7Ap0dYXt1rr1mvJutRdKZCxv2sVBnlNJ Cx0lkKtp9v/sLdf4UCPHWTkj8yA7ccA4cV9s4YijjfqPkSoEZFU02hjIX8wYQTkNnRNr KA2zU7TpFMRpZTHRL6G8GQZqRkZZdhBf/vFY5Zc7fEhjK5RnBL83sGJjHQxHdaD4x+2e pzxim8SVpWGCbVTG1hCOJOXAlsYcpAeFLWBLqDvMDYDHjMBvLqAJpKEMYnVok6KDEBDR G0Fw== X-Gm-Message-State: ANoB5pkTeFjXHzj2HFf9jKHQXunxCTZLxVGmY2ow5xykrGpYTlVsBsD5 SJTEDDSrXrN7FdbKZxFI4SZPKYPjOMyA20bc X-Google-Smtp-Source: AA0mqf4Vcxmzo0O9olZaWwPSMt6w0cZ12ZE8hpFLVesGsxcG2I0D+bYsEXKJ5CYTF3EtOlVJTvymcw== X-Received: by 2002:a05:6808:1899:b0:35a:82a9:3cb8 with SMTP id bi25-20020a056808189900b0035a82a93cb8mr3668621oib.297.1667828171180; Mon, 07 Nov 2022 05:36:11 -0800 (PST) Received: from ?IPV6:2804:1b3:a7c0:a9f4:fc60:ae8f:c4b6:cf0a? ([2804:1b3:a7c0:a9f4:fc60:ae8f:c4b6:cf0a]) by smtp.gmail.com with ESMTPSA id q24-20020a056830233800b006619f38a686sm2858410otg.56.2022.11.07.05.36.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Nov 2022 05:36:09 -0800 (PST) Message-ID: Date: Mon, 7 Nov 2022 10:36:06 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH v2 2/4] Rewrite find_cxx_header config configure.ac Content-Language: en-US To: Florian Weimer , Adhemerval Zanella via Libc-alpha Cc: Fangrui Song References: <20221102145559.1962008-1-adhemerval.zanella@linaro.org> <20221102145559.1962008-3-adhemerval.zanella@linaro.org> <874jvakig9.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <874jvakig9.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 07/11/22 10:22, Florian Weimer wrote: > * Adhemerval Zanella via Libc-alpha: > >> diff --git a/configure b/configure >> index fc3d7842de..e23ea95a49 100755 >> --- a/configure >> +++ b/configure >> @@ -5669,8 +5669,8 @@ fi >> # copy of those headers in Makerules. >> if test -n "$CXX"; then >> find_cxx_header () { >> - echo "#include <$1>" | $CXX -M -MP -x c++ - 2>/dev/null \ >> - | sed -n "\,$1:,{s/:\$//;p}" >> + echo "#include <$1>" | $CXX -H -fsyntax-only -x c++ - 2>&1 \ >> + | awk '$1 == "."{print $2}' >> } >> CXX_CSTDLIB_HEADER="$(find_cxx_header cstdlib)" >> CXX_CMATH_HEADER="$(find_cxx_header cmath)" > > Shouldn't this use $ac_cv_prog_AWK? It should be $AWK in fact, I will fix it before commit.