From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 988 invoked by alias); 9 Jan 2018 10:47:17 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 978 invoked by uid 89); 9 Jan 2018 10:47:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Subject: Re: [PATCH 1/2] Linux/x86: Update cancel_jmp_buf to match __jmp_buf_tag [BZ #22563] To: "H.J. Lu" , Andreas Schwab Cc: GNU C Library References: <20171207174057.GA32196@gmail.com> <7e890f53-c331-d86e-ad13-b380a69d99eb@redhat.com> <814691a7-d946-1794-d6d8-7861f9ed2067@redhat.com> <08cf7c54-8bf0-27c0-863a-65cb76dd0728@redhat.com> <4e80a87a-c90a-85a6-daf1-cbbf71d0bf58@redhat.com> From: Florian Weimer Message-ID: Date: Tue, 09 Jan 2018 10:47:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2018-01/txt/msg00268.txt.bz2 On 12/18/2017 03:48 PM, H.J. Lu wrote: > On Mon, Dec 18, 2017 at 6:44 AM, Andreas Schwab wrote: >> On Dez 18 2017, "H.J. Lu" wrote: >> >>> This patch adds bits/types/__cancel_jmp_buf_tag.h to define struct >>> __cancel_jmp_buf_tag so that Linux/x86 can add saved_mask to >>> cancel_jmp_buf. >> >> Isn't that an ABI change? >> > > Yes, this change is exposed to application via . The backward > binary compatibility is provided by > > https://sourceware.org/ml/libc-alpha/2017-12/msg00208.html This doesn't seem to work: I have no idea what is going on, but if we can't find the root cause, I think we should revert all the setjmp changes. Thanks, Florian