From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 71454 invoked by alias); 31 Oct 2016 19:50:19 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 71408 invoked by uid 89); 31 Oct 2016 19:50:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM autolearn=no version=3.3.2 spammy=H*MI:sk:1477939, H*i:sk:1477939, H*f:sk:1477939 X-HELO: mail-oi0-f48.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=uNhMKHph1GG/hi1XRCZgiJNI6CSVUE9g5DgLrmCBQug=; b=BhPJEZgYSnYJ4o1j7s9oe7LIYFiAFI00/o8kFPL8cMnB+SH7LDPAY11iaMiES9QPYF /I614h0/C9IrX8ZzXikCLTEZ+p3eTIy6fPm0nMIdkz9jgPLx8lDfls0/7qfOvlN1g0/c FfuGVZcft6F00RThmuivi9GA3y0N50BwWRBvOM/d8hmNIaAHyBGf1XmT2Z8o0dTjNDE3 zWny3M795O6A+Zob5oye5FFMtkCiOV+i1eH50kAwdIMLf6ttbRHpyaezRdDWYgoQtkXJ 9r3mNh6ZL2yBwaVFFwnbjDyUqBbYgYSNhifS0AKbl3EqyWTYkTivikoEL6rx7wu/9tsP oN1Q== X-Gm-Message-State: ABUngvd5J1kdk0MeVvqbjMO+q1HXkre7Mi+2g1/EWfETcoM20N0bQ+J/ljKbcXaQsncLbVjV X-Received: by 10.107.139.68 with SMTP id n65mr11920418iod.166.1477943415865; Mon, 31 Oct 2016 12:50:15 -0700 (PDT) Subject: Re: [PATCH v3] Fix -Os related build and test failures. To: Steve Ellcey References: <1477939106.2891.37.camel@caviumnetworks.com> Cc: GNU C Library From: Carlos O'Donell Message-ID: Date: Mon, 31 Oct 2016 19:50:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1477939106.2891.37.camel@caviumnetworks.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-10/txt/msg00602.txt.bz2 On 10/31/2016 02:38 PM, Steve Ellcey wrote: > Carlos, > > I am running into a build problem with your patch. weight.h uses the > DIAG_* macros but does not include libc-internal.h, where those macros > are defined. Apparently it assuming whatever file includes it will > include libc-internal.h. > > That is not happening for me when I compile > string/strxfrm_l.c, posix/fnmatch.c, and posix/regex.c. regex.c does > not include weight.h itself but includes regex_internal.h which > includes weight.h). I think there are more files with this problem > too, I haven't finished my build yet. > > I am building on an aarch64 machine with a prerelease version of GCC > 7.0, I think the compiler I am using may be why other people are not > seeing this error. > > I am not sure if weight.h should include libc-internal.h, since that is > what uses it, or if the .c and .h files that include weight.h should > also have include libc-internal.h. I have fix and I'm just testing it again on x86_64. Thank you for your patience :-) Cheers, Carlos.