From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-x932.google.com (mail-ua1-x932.google.com [IPv6:2607:f8b0:4864:20::932]) by sourceware.org (Postfix) with ESMTPS id 6FDE03858C27 for ; Wed, 24 Nov 2021 12:20:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6FDE03858C27 Received: by mail-ua1-x932.google.com with SMTP id p2so4569991uad.11 for ; Wed, 24 Nov 2021 04:20:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=OMoaAPNsuYsBxbYQqsTV0ZYSxo1OKlvL9i2iOFzEQ4U=; b=ChuJ8B2tf3p6mrBEVoYV7K0/80jjc/Agtvd/yM3bbcvLAts6IFc7sLhVyapD+qSSQw Mo9ToxV2dPvDNwMf3DRQmfSoeFUZGXroclbc58n9xKk7WOJZdykseerIOSWDGMT5RoZE VgVHRpllN/4DeoUPXWn3sJPvELFQdSR6u26Ocdup+TEhwiJ/+0VddZ+I9h07OmJTIC8a jTirZJI2DrsSTffvZPcCV7OzDTUbkE7wlwnfOOa0eZ3Do4HdGIVhSJty3lQLWwD/t41m 1Zxkf9cyNDxkUOOZ+KKBzQdrmrMtxMvlpJGCxO4WBQrGh0sY7F9Co7lp0PcOgvot32aW 5XZA== X-Gm-Message-State: AOAM533K6aDcpgM9sc57eittJy+42XLGDVLCurbfJoCNyJMfZqxao8Ks Zb2ySrPLNdAokWZvbDEDwc+x6Q== X-Google-Smtp-Source: ABdhPJxvOJ6RcX2K1AsRRMAmNhLxwHnBHY81By4xcF2IUwhXpjxN6RjSi5S924flv1tNgjGpSdh/1Q== X-Received: by 2002:ab0:3898:: with SMTP id z24mr9801555uav.26.1637756403746; Wed, 24 Nov 2021 04:20:03 -0800 (PST) Received: from ?IPV6:2804:431:c7cb:e054:c4ff:45cd:d32c:cc55? ([2804:431:c7cb:e054:c4ff:45cd:d32c:cc55]) by smtp.gmail.com with ESMTPSA id b11sm8377737vsp.6.2021.11.24.04.20.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Nov 2021 04:20:03 -0800 (PST) Message-ID: Date: Wed, 24 Nov 2021 09:20:01 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.2 Subject: Re: [PATCH v2] io: Refactor close_range and closefrom Content-Language: en-US To: Florian Weimer Cc: Adhemerval Zanella via Libc-alpha , Samuel Thibault , Sergey Bugaev References: <20211108172817.2235239-1-adhemerval.zanella@linaro.org> <87r1b5op82.fsf@oldenburg.str.redhat.com> <87mtltoj5k.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella In-Reply-To: <87mtltoj5k.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-15.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Nov 2021 12:20:05 -0000 On 24/11/2021 09:03, Florian Weimer wrote: > * Adhemerval Zanella: > >>> diff --git a/sysdeps/mach/hurd/kernel-features.h b/sysdeps/mach/hurd/kernel-features.h >>> index 7d4eaee0a6..5fd37a6d7b 100644 >>> --- a/sysdeps/mach/hurd/kernel-features.h >>> +++ b/sysdeps/mach/hurd/kernel-features.h >>> @@ -19,3 +19,5 @@ >>> /* This file can define __ASSUME_* macros checked by certain source files. >>> Almost none of these are used outside of sysdeps/unix/sysv/linux code. >>> But those referring to POSIX-level features like O_* flags can be. */ >>> + >>> +#define __ASSUME_CLOSE_RANGE 1 >> >> It does add it here (I also checked with a build for i688-gnu). > > Hmm, this doesn't match existing practice. We haven't unified > implementations in light of such divergence, I think. If the Hurd > developers don't object, it should be fine, though.. This was used before, we still have some leftovers from it: nscd/nscd.c:306:# ifndef __ASSUME_IN_NONBLOCK resolv/res_send.c:1035:#ifndef __ASSUME_SENDMMSG resolv/res_send.c:1081:#ifndef __ASSUME_SENDMMSG resolv/res_send.c:1100:#ifndef __ASSUME_SENDMMSG You have also cleanup some other assumes from Hurd: dup3 (b48061e1a534a242), O_CLOEXEC (cef9b65376a04430), and accept4 (e92030239abb4038).