From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id CA1FB385E02B for ; Thu, 2 Jun 2022 13:54:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CA1FB385E02B Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-570-B7QAoyQqM_GizkZxW2p9QQ-1; Thu, 02 Jun 2022 09:53:59 -0400 X-MC-Unique: B7QAoyQqM_GizkZxW2p9QQ-1 Received: by mail-qv1-f69.google.com with SMTP id q36-20020a0c9127000000b00461e3828064so3467774qvq.12 for ; Thu, 02 Jun 2022 06:53:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:organization:in-reply-to :content-transfer-encoding; bh=x5PFyZw9VYBNPM9rmAi1RJg7r2/s4cglENHWHnnkI18=; b=zLGcTJc2ZZzSi8ADTYkQlhdT46ruA+SC1v8zI7w+SLGx422uV7GsrQb2VA29qtOAMc PX9wnPzActU9mJsZMH9RZmvV3fgofBQxW8lToQkKAC92m6Rv7nLfBU5MbZueZn0Jce0J 1wZSTBkAatZQYvAOSAC0CzaVTDsPmbCYPPUREwr9U3RPlfUlhKzOflHEWabutFlO83am uCoSbAPr7cyoANuXtekGYoX3UrM0bFciEiALchg6CMV+lz61YjOwvBME510sHfw3cNe/ mlJsdIPyVzBoRQD+QdNOav8hFkEwqAziB3bpiQC/A95vjlHeNit5jzJMbuBUyux43y7c Fvag== X-Gm-Message-State: AOAM531ovKesGFaBExsT6jpLVaZmSWHndv2WRIKWC2ZPYOYf1HiMdD5+ eIznq/t36iHBPZu5D6ijMpH24Y1iAAHgKHOBUEnP6mkyBU90vcdjmZO9OSIpVpMcKsMjCVfhVjq 4PXAitklZCHtC8uPaPv1j X-Received: by 2002:a37:aac4:0:b0:6a6:7ebd:6793 with SMTP id t187-20020a37aac4000000b006a67ebd6793mr1305628qke.443.1654178038903; Thu, 02 Jun 2022 06:53:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzHh1081LoIfxALFbfOfQxaypFIfEiw4xfaNslQ/a/x5fbhObWRbie/Gm7p5XCD/nALfZhe2g== X-Received: by 2002:a37:aac4:0:b0:6a6:7ebd:6793 with SMTP id t187-20020a37aac4000000b006a67ebd6793mr1305615qke.443.1654178038672; Thu, 02 Jun 2022 06:53:58 -0700 (PDT) Received: from [192.168.0.241] (135-23-175-80.cpe.pppoe.ca. [135.23.175.80]) by smtp.gmail.com with ESMTPSA id 129-20020a370a87000000b006a353b7bf78sm3178548qkk.122.2022.06.02.06.53.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jun 2022 06:53:58 -0700 (PDT) Message-ID: Date: Thu, 2 Jun 2022 09:53:57 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH] linux: Set tst-pidfd-consts unsupported for kernels headers older than 5.10 To: Adhemerval Zanella , libc-alpha@sourceware.org, Joseph Myers , Matheus Castanho References: <20220602115244.904088-1-adhemerval.zanella@linaro.org> From: Carlos O'Donell Organization: Red Hat In-Reply-To: <20220602115244.904088-1-adhemerval.zanella@linaro.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-16.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_NUMSUBJECT, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Jun 2022 13:54:02 -0000 On 6/2/22 07:52, Adhemerval Zanella via Libc-alpha wrote: > Instead of fail trying to build the compare source file. The header appears in 5.9-rc2, but is missing from the final 5.9 release, and is only in the final 5.10. Confirmed. LGTM. Reviewed-by: Carlos O'Donell > --- > sysdeps/unix/sysv/linux/tst-pidfd-consts.py | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/sysdeps/unix/sysv/linux/tst-pidfd-consts.py b/sysdeps/unix/sysv/linux/tst-pidfd-consts.py > index 75df0ebed5..90cbb9be64 100644 > --- a/sysdeps/unix/sysv/linux/tst-pidfd-consts.py > +++ b/sysdeps/unix/sysv/linux/tst-pidfd-consts.py > @@ -34,6 +34,9 @@ def main(): > args = parser.parse_args() > > linux_version_headers = glibcsyscalls.linux_kernel_version(args.cc) > + # Linux started to provide pidfd.h with 5.10. > + if linux_version_headers < (5, 10): > + sys.exit (77) > linux_version_glibc = (5, 18) > sys.exit(glibcextract.compare_macro_consts( > '#include \n', -- Cheers, Carlos.