From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) by sourceware.org (Postfix) with ESMTPS id 0CD073858298 for ; Wed, 1 Feb 2023 17:55:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0CD073858298 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-pj1-x1035.google.com with SMTP id o13so18052417pjg.2 for ; Wed, 01 Feb 2023 09:55:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=g/QYBG5gh8iVeKFi13Eb2bcL8FQWRLGOekdpiAcqzHo=; b=Pali8fjB5o5sYeXZl9FSmK9nw2ABM6zt2RGGWXt8+QNj9fzq62lxppv0bSwTq1Fyow kd54e+4ftkVfRymWT8PWA3lBj1B5yQugXEnVIIAJgKAWZSHgUayopc45UpIUxkmqOhyG Ld6xT0dvKo4/2EZ2oSxAn296Gg+YVtriwC2l8DQ52lw1YcPVJ/hQTyWHdlPZqONXvwVR ZZidACCquxN1umjCh7r8dZTswNF/FwBfSxSZeyDz84J2gJnpE1rmZRjQmc/5t43D7y/b VR1UFQUrCi1YT2ZB3pmgNSlIajM9rDQcqV6xpMsXrKCmoKznsR/Zf1jU98i2GOII8Qfe l/4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=g/QYBG5gh8iVeKFi13Eb2bcL8FQWRLGOekdpiAcqzHo=; b=U0VuORBOqHCKz54c3Y1uPuJewg/K0VGO8yOM7knjuxYvQpjP86gl1ycwDKVnkBZKGn GZFqZowMlICnvBWRmyLBN+RUsb/L6C3aniRrWY36C8Zg6DsW76D+043BLvg+/rkbkPe6 zCpuX5xut8ITpIsIsGXnFEULkmtFckoAdPyWAUo7nN8AV67udkXHwiVPHIbdPktqAAzq MOFjOH4VuwpUmYSODUzX9+5FCLKwhk2dFORaf9nOG9HhUO8lQLv/ceRizl84tZSJLMV0 /ul+9CG7R+8ah60OZOkuj/PWO0VTY6pSYatMmuBEWMbTzfehmfd4OLzuF8JeX9NNLViH vdEA== X-Gm-Message-State: AO0yUKVP6NavzF/DJ2dqIr8ULgTINpiOjrPGrw31LQ1r4NuYHgd1IUbo tIdtnRHRmJawy/DozVy5Izt7Ng== X-Google-Smtp-Source: AK7set/czauUJITlSArK/eIew1TzhHHbYpy0lRro6ysEmEQuzWvSm5FOHx5xKkjwyVY4i7mchXHpOQ== X-Received: by 2002:a17:90b:3a85:b0:22c:9953:76c1 with SMTP id om5-20020a17090b3a8500b0022c995376c1mr2855301pjb.9.1675274146153; Wed, 01 Feb 2023 09:55:46 -0800 (PST) Received: from [192.168.50.50] (rrcs-173-197-98-118.west.biz.rr.com. [173.197.98.118]) by smtp.gmail.com with ESMTPSA id n6-20020a17090ade8600b00212e5068e17sm1616878pjv.40.2023.02.01.09.55.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Feb 2023 09:55:45 -0800 (PST) Message-ID: Date: Wed, 1 Feb 2023 07:55:42 -1000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v11 24/29] string: Hook up the default implementation on test-strcmp Content-Language: en-US To: Adhemerval Zanella , libc-alpha@sourceware.org, Noah Goldstein , Jeff Law , Xi Ruoyao References: <20230201170406.303978-1-adhemerval.zanella@linaro.org> <20230201170406.303978-25-adhemerval.zanella@linaro.org> From: Richard Henderson In-Reply-To: <20230201170406.303978-25-adhemerval.zanella@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/1/23 07:04, Adhemerval Zanella wrote: > --- > string/test-strcmp.c | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) Reviewed-by: Richard Henderson r~ > > diff --git a/string/test-strcmp.c b/string/test-strcmp.c > index ceb0d29c74..fa3161688c 100644 > --- a/string/test-strcmp.c > +++ b/string/test-strcmp.c > @@ -101,6 +101,28 @@ typedef int (*proto_t) (const CHAR *, const CHAR *); > > IMPL (STRCMP, 1) > > +/* Also check the default implementation. */ > +#undef STRCMP > +#undef libc_hidden_builtin_def > +#define libc_hidden_builtin_def(a) > +#undef libc_hidden_def > +#define libc_hidden_def(a) > +#undef weak_alias > +#define weak_alias(a, b) > +#undef attribute_hidden > +#define attribute_hidden > +#ifndef WIDE > +# define STRCMP __strcmp_default > +# include "string/strcmp.c" > +# define STRCMP_DEFAULT STRCMP > +#else > +# define WCSCMP __wcscmp_default > +# include "wcsmbs/wcscmp.c" > +# define STRCMP_DEFAULT WCSCMP > +#endif > +IMPL (STRCMP_DEFAULT, 1) > + > + > static int > check_result (impl_t *impl, > const CHAR *s1, const CHAR *s2,