From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from black.elm.relay.mailchannels.net (black.elm.relay.mailchannels.net [23.83.212.19]) by sourceware.org (Postfix) with ESMTPS id BACDE385841F for ; Mon, 12 Sep 2022 20:27:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BACDE385841F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gotplt.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 2F91E6C11B5; Mon, 12 Sep 2022 20:27:31 +0000 (UTC) Received: from pdx1-sub0-mail-a305 (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id C6CA96C1344; Mon, 12 Sep 2022 20:27:30 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1663014450; a=rsa-sha256; cv=none; b=K9WodlqRCYMek4S18IQo/sQ700+AQiTxijY+WpJQhsNjZpy6157di7v273QZIEhnjCXfUw gssan7iWa/WZQSaLtFFOFFcmgqWLeojNJBrireUhAp4Xj6OxdtiiLGkcgablYa5vG5t2od xzyXNMu31vQkjLgPoh9mKWJjAcKToaWCDbqHXFI1IKBjASV7TriGtKohZAEsRVc5XbHz4f xwFkPANXk4HcBxFh+UGvkpduDdQypNdMkR87ZrC9Cb4qzqR0EJrfwhpAc+Xv5xwP9ZNpGG cMdZyTWDnl3eEZRpxXSTOsUW7KnsDQGA8V7PpmgZoWaZeCRtA8ZYKUx/KcH5TA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1663014450; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gCfqhb/W2IRfgJr/7JWwBgUHlWO5pSbrrwrsHOsADno=; b=B/a53nGWMhr50fBYJRRdyI2Vd+4Tw5FWBSGa24eWLIhDqevUmy53BRg27A8ZR8rd+vgj/I q5dqw9CTzLeamsK/ssXSrQpIZXtqViNBnuLgvGCXiNwlmRUUaQvM7U3Bezmw6n5vc5Wnwp 01pzOoyekoXIdg9VkZfDiJRW0Oj8E2hHd5eXPgkDqc15fgzugx/MJroz7ihnTVrVOLQVo6 QHkI8sd/sZqaEu0ro+ousXHvxMnLtfB6MpEuBbWgcikNo9bIroD8+xi6Fdl4TOhAX3MV6O 4H4j8ZeoguSeo3lPk+WO4M2GK7jELu+JPW4u3tLlhPXyHPHnweQgaParhvdFqw== ARC-Authentication-Results: i=1; rspamd-686945db84-bqrxs; auth=pass smtp.auth=dreamhost smtp.mailfrom=siddhesh@gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Blushing-Inform: 6655a56203b36733_1663014451048_1434287981 X-MC-Loop-Signature: 1663014451048:3974506374 X-MC-Ingress-Time: 1663014451048 Received: from pdx1-sub0-mail-a305 (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.120.38.138 (trex/6.7.1); Mon, 12 Sep 2022 20:27:31 +0000 Received: from [192.168.0.182] (bras-vprn-toroon4834w-lp130-16-184-147-84-238.dsl.bell.ca [184.147.84.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a305 (Postfix) with ESMTPSA id 4MRJ760bLFzcC; Mon, 12 Sep 2022 13:27:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gotplt.org; s=dreamhost; t=1663014450; bh=gCfqhb/W2IRfgJr/7JWwBgUHlWO5pSbrrwrsHOsADno=; h=Date:Subject:To:From:Content-Type:Content-Transfer-Encoding; b=lbsHElItNE2ZHy6eUBJSPtlDB21yrqNOfUGZqbdEJY9nPUTa725H1o0a9OJkFtSqG osVpntMTtJc0Sv5nS1z731EiFrp/c87PUKFK5Z/3hzqzGnrWq4pgFGLx9HWuUKOhaF cTUC4ak/kG6GqsEPsheMjJnjJYp3S6DRny7WS1HVTcV8aZmz3YhAaxjyrvKvm6p97d Cmm7Vu8W3UqvkjlxOmLl7McpJ5po15OdCUAG2hgffee9vtkaXMfydGBuaV44hQaivG gi8/aSDYUrBwccWGw4bEfUFW2zfoTRQ+O/r46kLCw6rQfo/04yM7+9dKBM33PVxpeZ OfpJjynGwEAsw== Message-ID: Date: Mon, 12 Sep 2022 16:27:25 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH] Makefules: fix MAKEFLAGS assignment for upcoming make-4.4 Content-Language: en-US To: Sergei Trofimovich , libc-alpha@sourceware.org References: <20220909115039.3802300-1-slyich@gmail.com> From: Siddhesh Poyarekar In-Reply-To: <20220909115039.3802300-1-slyich@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3032.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_NUMSUBJECT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2022-09-09 07:50, Sergei Trofimovich via Libc-alpha wrote: > make-4.4 will add long flags to MAKEFLAGS variable: > > * WARNING: Backward-incompatibility! > Previously only simple (one-letter) options were added to the MAKEFLAGS > variable that was visible while parsing makefiles. Now, all options > are available in MAKEFLAGS. > > This causes locale builds to fail when long options are used: > > $ make --shuffle > ... > make -C localedata install-locales > make: invalid shuffle mode: '1662724426r' > > The change fixes it by passing eash option via whitespace and dashes. > That way option is appended to both single-word form and whitespace > separated form. > > Signed-off-by: Sergei Trofimovich > --- Thanks, that's the right direction IMO but allowing word form flags will break this check too: ifeq "$(findstring s,$(MAKEFLAGS))" "" # if not -s which is present in Makerules, Makeconfig and elf/rtld-Rules since the s will also match, e.g. --shuffle. Those checks need to be fixed too. Thanks, Siddhesh