From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x731.google.com (mail-qk1-x731.google.com [IPv6:2607:f8b0:4864:20::731]) by sourceware.org (Postfix) with ESMTPS id AAA913857C5F for ; Wed, 24 Mar 2021 14:43:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org AAA913857C5F Received: by mail-qk1-x731.google.com with SMTP id y18so18198065qky.11 for ; Wed, 24 Mar 2021 07:43:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=bnsoAeMMh6jGr2xRZfqLX1eJsTsOZ/HZHnoHunr6P0Q=; b=rbwTx5nu0D+xODrrJK+YDGVaXegDkfslbkKD60tM2bZTvrIy/+bNmNycmedr7Kr3OQ 0tPYkekoEnPB8A6W7FQNyxe73cTmkLa843PL0DatO5bn/0seU+qH78bUsJtbxwvUxzMQ zJqPh5BXdVZwm28l8B1n4U9hx4PoYk9bdKdJcfY/QIDfrlLbLUYYUeTmsuCRD+hrfPDr kKCLQ218274MQ9WlnOi02xchOj+dh8IW7W358SPjnQXg109tKgB9/jQYlFE3xfVQuwp9 7iuyhvL3ddJCEjTzc4mkW8Y0roYfbChwphq54+yLzIXM+e8kKWYUrH+wq59ls6EkVWUg mxMA== X-Gm-Message-State: AOAM530R5bMYXoW8x0dOJueMPgnbb42NRjjegvb8sK1j8t8z3ZZp3du1 1eXA3H0kKDMxCfF5laNczP+4r4v9Apzg8Q== X-Google-Smtp-Source: ABdhPJxM3qmhOO7O6WceiJmap98nF1UfjZExyAUDmwAorCWWnQpA9RwOM1GhQ9YQln2LGthSUKDKyw== X-Received: by 2002:a05:620a:91b:: with SMTP id v27mr3444918qkv.201.1616597000136; Wed, 24 Mar 2021 07:43:20 -0700 (PDT) Received: from [192.168.1.132] ([177.194.41.149]) by smtp.gmail.com with ESMTPSA id k127sm1824554qkc.88.2021.03.24.07.43.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Mar 2021 07:43:19 -0700 (PDT) Subject: Re: [PATCH v3 25/37] nptl: Move pthread_getspecific, __pthread_getspecific into libc To: Florian Weimer Cc: libc-alpha@sourceware.org References: <731956b0cd5783de2b09d1754bee65456791e4ea.1615914632.git.fweimer@redhat.com> <6418c3a1-3ead-8a0d-8312-2bc16b399d98@linaro.org> <87czvowra8.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella Message-ID: Date: Wed, 24 Mar 2021 11:43:17 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <87czvowra8.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Mar 2021 14:43:23 -0000 On 24/03/2021 11:38, Florian Weimer wrote: > * Adhemerval Zanella: > >>> diff --git a/nptl/Versions b/nptl/Versions >>> index d44958f5b6..218d6bbbf8 100644 >>> --- a/nptl/Versions >>> +++ b/nptl/Versions >>> @@ -1,5 +1,6 @@ >>> libc { >>> GLIBC_2.0 { >>> + __pthread_getspecific; >>> __pthread_key_create; >>> __pthread_once; >>> _pthread_cleanup_pop; >>> @@ -29,6 +30,7 @@ libc { >>> pthread_equal; >>> pthread_exit; >>> pthread_getschedparam; >>> + pthread_getspecific; >>> pthread_key_create; >>> pthread_mutex_destroy; >>> pthread_mutex_init; >>> @@ -88,8 +90,10 @@ libc { >>> } >>> GLIBC_2.34 { >>> __pthread_cleanup_routine; >>> + __pthread_getspecific; >> >> Why do we need a __pthread_getspecific for 2.34? > > I can turn __pthread_getspecific into a compat symbol once tss_get has > been moved into libc. Then we do not need > __pthread_getspecific@@GLIBC_2.34 anymore. Right. > > As discussed before, I do not want to introduce > __pthread_getspecific@@GLIBC_PRIVATE because relinking applications > which previously used the public __pthread_getspecific symbol will > suddenly switch to the internal GLIBC_PRIVATE symbol, which would be a > regression. > > (__pthread_getspecific is not used by libstdc++.) Yeah, I am still not 100% convinced that relinking should something we should be constrained but it looks ok for now.